Skip to content

Include suggested acceptance bodies in initial context reads - #7871

Open
loopx-agent wants to merge 4 commits into
mainfrom
codex/c1-outcome-first-read
Open

loopx-agent wants to merge 4 commits into
mainfrom
codex/c1-outcome-first-read

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

The initial reader exposes outcome IDs even when the acceptance owner already provides complete relationship navigation. Applicable bodies then need another detail request. This change includes those suggested bodies in the starting selection, including peer dependencies, while leaving other outcomes indexed and addressable.

Base: main. Bounded precursor to C1/C2 in controller-executor-unified-contract-v0.md §11; the complete program remains open.

Author Declaration

Written by: model_agent — Codex, OpenAI GPT-6 family.

Implemented against docs/reference/required-work-context.md and the C1/C2 contract at e9eda527afd5fcb262ee7c199e1822b1a936cc24.

Criterion Disposition Implementation / evidence
Applicable acceptance and cross-Agent constraints stay complete implemented Existing navigation owner supplies suggestions; positive regression includes a peer dependency, a final cancellation clause and unknown fields.
Capture identity, revisions and incomplete coverage remain explicit implemented Exact Goal/Agent/Todo and source-revision binding; mismatched, legacy, ambiguous and incomplete sources retain the existing detail route.
Other outcomes remain discoverable; selected EOF is not full delivery implemented Original index/detail addresses and read obligations preserved; immutable capture and receipt negative checks.
Host-independent defaults, unread ledger and full-cost/outcome qualification deferred Existing C1/C2 program; this proposal changes only the existing initial-reader selection.

Self-check: reviewed the complete seven-path diff and original instruction selection, preserved the latest agenda-read changes, ran the affected Python/TS suites, matched reader workload and static checks.

Scope And Continuation

Move the existing initial-selection policy into the existing progressive-context owner and reuse the registered navigation schema. The generic RFC 6901 reader, activation defaults, saved capture/view/Delta bytes, configuration and permission owners remain unchanged. No new capability, store, setting or scope heuristic.

The native first-read command and public CLI reader use the same policy; the CLI checks require no Session Hook. Folded supporting material keeps its original read obligations. C1/C2 consumer migration, unread discovery, installed adoption and outcome/full-cost qualification remain outside this slice. It can be reviewed and reverted independently.

Validation

  • Tested source revision: d48b6238b9d50b83c155bb4b031ce67079b6f9d3; final head 4bc686fda72b8309ab9b0c0b1d299128f858c900 merges main's documentation-only change. Runtime and test blobs are unchanged.
  • Run state: finished. Inputs: synthetic/public fixtures. No models or benchmark jobs launched.
Check kind Result Evidence / limitation
regression_parity passed The same positive first-read case fails on target runtime 2f099b8a (runtime/test blobs unchanged at e9eda527a) with the missing whole outcome, then passes with this change.
integration / real_entrypoint passed Five modules: context_first_read, outcome_context_navigation_cli, progressive_native_context, context_delivery_cli, codex_context_resume: 254 passed. Includes isolated real File/SQLite, marked/unmarked Goal and explicit/inherited activation.
unit / static passed context_selection, context_delivery and outcome_context_navigation TS suites: 57 passed, 1 PostgreSQL skip; control-plane typecheck passed.
real_entrypoint / regression_parity passed 20 isolated public-reader invocations with fixed source commits and immutable captures. Same required-body coverage in all eight base/head pairs. Incomplete navigation and explicit detail controls are byte-identical.
static passed Bilingual staged/head checks, whitespace, diff-scoped semantic advisory and public-boundary scan. Advisory found no supported vocabulary carriers; dynamic semantics remain outside that scanner.
real_backend not_run PostgreSQL integration environment unavailable; no PostgreSQL qualification claimed.

For initial pages plus all applicable outcome detail and a later peer-body expansion:

Provider / output limit Reads before → after CLI stdout bytes before → after
File / 16,000B 4 → 3 35,893 → 34,934
File / 64,000B 3 → 2 34,825 → 33,866
SQLite / 16,000B 4 → 3 35,921 → 34,962
SQLite / 64,000B 3 → 2 34,851 → 33,892

Each complete-navigation case saves 959B of stdout (about 2.7%) and one logical context-select call. The initial selection itself grows by 5,937B; the complete read workload is the comparison. Serialized bridge parameter/result JSON also falls because one request no longer carries the capture. These are component measurements, not framed traffic, model tokens, latency, billing or accepted-outcome benefit. Saved-view file bytes are unchanged.

Earlier stale-reference fixture failures were reproduced on the unchanged baseline and corrected with the existing shared reference oracle. An initial missing test dependency was repaired locally before the final TS run. Those attempts do not count as passing validation. No installed/App/model adoption or whole C1 closeout is claimed.

Frontend / Visual Evidence

UI impact: none. Existing model-facing native/common-reader journey; no page, settings or documentation-chrome change. Screenshots and preview: N/A. Packaged/installed qualification remains separate.

Boundary Checklist

  • Public diff and description contain no private operating state, raw evidence, credentials or local paths.
  • Scope is the existing initial reader; no benchmark treatment, scoring or budget changes.
  • English/Chinese RFC pair updated and checked.
  • Every commit carries a DCO sign-off.
  • Maintainer review and merge authorization remain separate; this PR does not request a default rollout.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…t-read

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

# Conflicts:
#	loopx/control_plane/quota/turn_envelope.ts
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant