Repository navigation
Conversation
…sion wrapper - Delete coordination/local_snapshot.py: no caller has remained since #6396 removed the last Todo mutation consumer of todo_snapshot_from_mapping. - Delete build_standing_decision_authority() and its standalone todo.standing_decision.project handler and request decoder. Production reads already reach the shared TS owner through the composed todo.read batch; tests and the example now exercise that path with the same chronology, revocation, scope and invalid-item assertions, plus a TS case for contradictory authority without explicit legacy order. - Correct the stale retention row in the retirement ledger and record the wrapper retirement in the TS migration checkpoint (EN and zh-CN). Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Signed-off-by: hhyykk <4408344+hhyykk@users.noreply.github.com>
hhyykk
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
November 2, 2026 04:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
coordination/local_snapshot.pylost its last caller in refactor(authority): retire legacy Markdown mutation callers #6396, but the retirement ledger still said to keep it for Todo mutation authorization.build_standing_decision_authority()was called only by tests and one example; production reaches the same TS owner through the composedtodo.readbatch.loopx-project/loopx:main. No issue closure claimed.Author Declaration
Implemented against
e9eda527a.local_snapshot.pyhas no reference in code, tests, packaging or manifestsloopx/control_plane/coordination/local_snapshot.py(deleted)build_standing_decision_authority()and its standalonetodo.standing_decision.projecthandler and request decoder; keepstanding_decision_source_items()and the shared TS ownerloopx/control_plane/todos/standing_decision.py;loopx/control_plane/todos/standing_decision.ts;loopx/control_plane/effect_runtime_handlers.tstests/control_plane/test_standing_decision_order.py;tests/control_plane/test_todo_decision_scope_consistency.py;tests/control_plane_ts/standing_decision.test.tstodo.readpath; add contradictory-authority refusal without explicit legacy orderexamples/control_plane/todo-standing-decision-authority-smoke.py;tests/control_plane_ts/effect_runtime_fairness.test.tsdocs/architecture/rfcs/ledger/shared-goal-authority-state-provider-v0/2026-09-28-retirement-cadence{,.zh-CN}.md;docs/architecture/rfcs/typescript-control-plane-migration-v0{,.zh-CN}.mdscripts/check_rfc_bilingual.py --base origin/main --head HEADMigration economics receipt
todos/standing_decision.tsviatodo.read; lease facts with native executorslocal_snapshot.py, 33 Python wrapper/imports, 9 TS decoder/schema, 1 handler registration, 1 docstring line)local_snapshot.py, the Python wrapper and the standalone RPC are deleted nowScope And Continuation
work_items/delivery_outcome.py, was analyzed and deliberately not included. Several refusal paths (Host-result validation, the slot-accounting fallback scan, the missing-outcome refusal in refresh) cross no TS request today, so a cutover would add a cross-runtime call or reorder refusal.Validation
unitpassedunitpassedstanding_decision,effect_runtime_fairness,todo_read,decision_scope,archive_capture,todo_archive_selection: 54 passed, 0 failed.real_entrypointpassedexamples/control_plane/todo-standing-decision-authority-smoke.pythrough the composed read andquota should-run.staticpassedcheck_rfc_bilingual.py --base origin/main --head HEAD;loopx canary premerge --from-git-diff --git-diff-base origin/mainincluding the maintainability ratchet and semantic vocabulary drift; merge gate passed.legacy_source_order(for example the string"false"), while the productiontodo.readpath already treats any value other thantrueas not-legacy. That is existing production behavior, not a change introduced here.See validation disclosure guidance.
Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
Boundary Checklist
none.Signed-off-bytrailer (git commit -s).