Skip to content

test(collaboration): keep delivery fixtures on an active source Turn #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Nov 1, 2026
Merged

test(collaboration): keep delivery fixtures on an active source Turn #7835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion tests/control_plane/test_peer_source_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,37 @@ def source_request(tmp_path, monkeypatch, *, provider="file", colocated=False):
response = apply_context_handoff(
controller, {"kind": "external_audience"}, session, turn,
{"context_handoff": {"goal_id": "goal-a", "agent_id": "agent-a"}},
{"authorization_scope_id": "synthetic-host-scope"}, execution_allowed=lambda: False,
# The source Turn is active. Worker launch separately requires an
# execution_binding_id, which this delivery-only request does not have.
{"authorization_scope_id": "synthetic-host-scope"}, execution_allowed=lambda: True,
)
assert response["context_execution"]["submitted"] is False
receipt = response["context_handoff_receipt"]
store.update_turn(session["session_id"], turn["turn_id"], status="completing", response=response)
store.finalize_managed_turn_completion(session["session_id"], turn["turn_id"])
return root, registry, store, session, turn, receipt


@pytest.mark.parametrize("provider", ["file", "sqlite", "source_session"])
def test_stopped_source_cannot_republish_a_previous_delivery(tmp_path, monkeypatch, provider):
root, registry, store, session, turn, _ = source_request(tmp_path, monkeypatch, provider=provider)

def snapshot():
return {str(path.relative_to(root)): path.read_bytes() for path in root.rglob("*") if path.is_file()}

before = snapshot()
controller = SimpleNamespace(store=store, coordination_runtime_root=root,
registry_path=registry, manager_scope_resolver=None)
response = apply_context_handoff(
controller, {"kind": "external_audience"}, session, turn,
{"context_handoff": {"goal_id": "goal-a", "agent_id": "agent-a"}},
{"authorization_scope_id": "synthetic-host-scope"}, execution_allowed=lambda: False,
)
assert response.get("context_handoff_receipt") is None
assert not response.get("context_execution", {}).get("submitted", False)
assert snapshot() == before


@pytest.mark.parametrize("provider", ["file", "sqlite", "source_session"])
@pytest.mark.parametrize("publication", ["transcript", "provider"])
def test_source_revocation_fences_original_return(tmp_path, monkeypatch, provider, publication):
Expand Down
Loading