Skip to content

fix(dashboard): 研究页先呈现汇报,指标并排可查 - #7522

Merged
huangruiteng merged 1 commit into
mainfrom
codex/research-reading-refinement-20261028
Oct 28, 2026
Merged

huangruiteng merged 1 commit into
mainfrom
codex/research-reading-refinement-20261028

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

已有研究汇报排在整块指标、来源和用量之后,手机首屏只能读到标签与数值。本次让已保存的研究汇报先回答“发现了什么、哪些仍未知、下一步验证什么”,宽屏将它与原生测量并排;深入阅读恢复全宽,引用原文留在报告的阅读上下文中。

同一合成示例中,1440×1000 的研究历程起点约从 925px 提前到 618px;390×844 的汇报起点从 806px 提前到 276px。数值、未知、六项判读、完整证据和调用权限沿用原 owner。

  • Outcome basis: maintainer-requested research-workbench readability refinement.
  • Intended base: loopx-project/loopx:main; merge base b69021498ef7483b1d2b190bc3f4c7bb6675c882.

Author Declaration

  • Written by: model_agent · OpenAI GPT-6 / Codex.
  • Specification: docs/development/design.md and docs/development/frontend-delivery.md at 5039d53f90ab1060611608ce35ce5878b40a1dcf.
Criterion Disposition Owning path Evidence
Earn the user's attention / primary reading question implemented goal-research-history.tsx saved report is visible in the default desktop and phone viewport
Populated-page review / default versus detail implemented goal-research-history.css responsive overview, full-width deeper reading, 16px long-body pressure checks
Task-first delivery / provenance and recovery implemented existing analysis and citation readers complete packaged HTTP/SQLite scenario, citation return, language, version and failure recovery

Scope And Continuation

Complete within this saved-report composition slice. The existing broader workbench and release work continues: installed-App adoption, new-generation semantic quality, measured packet attribution and release-film qualification remain separate. This PR adds no analysis generation, state owner or settings. It does not overlap the timeline aggregation and empty-state work in #7478.

Bounded scope review: reuse the existing reading layers, report, measurements and citation reader; one layout wrapper is sufficient. No additional abstraction or adjacent refactor was needed.

Validation

  • Tested revision: 5039d53f90ab1060611608ce35ce5878b40a1dcf; before images: b69021498ef7483b1d2b190bc3f4c7bb6675c882.
  • Run state: finished. Input classes: synthetic, public_fixture.
Check kind Result Evidence / limitation
static passed Dashboard npm run build:chat: typecheck and production bundle
real_entrypoint / real_backend passed complete packaged research-history scenario, isolated HTTP/SQLite, 260.638s; default report, six judgments, unknown/negative results, sources, keyboard focus, language/version, paging and recovery
integration passed packaged goal-showcase scenario, 3.606s
regression_parity passed saved and legacy reading, original sources, native values and failure branches retained; added actual first-viewport report visibility checks
manual / static passed eight synthetic screenshots inspected; zh/en 1440/390 long-content pressure retained 840–941-character paragraphs at 16px with no horizontal overflow; PNG metadata empty
static passed exact-diff quality receipt valid; changed-text public-boundary scan clean using the existing isolated scanner and an isolated empty-registry CLI
static / manual blocked standard premerge: 4 direct, 8 catalog and 1 boundary checks passed; eight binary-image manual holds remain for exact-head review. Overall premerge is held, not merge-ready

Intermediate failures remain recorded: the first reordered layout lost citation-return focus; keeping its source reader with the expanded report passed the final complete journey. An initial viewport assertion used the scroll position left by an expanded judgment; it now restores the initial viewport before testing it. A broad default-registry scan timed out before scanning; the isolated scan passed, with an empty-runtime warning retained. No full Python/control-plane/PostgreSQL suite was selected for this frontend-only composition change. No installed-App or independent audience qualification is claimed.

Frontend / Visual Evidence

Source-built packaged UI with an isolated real backend and clearly labelled synthetic study data. The short fixture demonstrates reading, not long-run research effectiveness. Public images contain no live operating context. All screenshots below are part of this exact head.

Desktop before:

Desktop before

Desktop after:

Desktop after

390px before:

Phone before

390px after:

Phone after

Expanded reading, English and long-content views

Expanded desktop

Expanded phone

English phone

Long overview

Attention review: report and native evidence share the wide viewport, then lead naturally into history; phone reading starts with the substantive report. Methods, sources and usage remain on demand. Expanded prose keeps the existing body size and full text. Unknown retention and alternative explanations remain explicit. Very long summaries still require reading and scrolling; no content was cut to force it into a viewport.

Craft review: no new grouping cards, colors or motion; the existing populated Goal showcase passed. Original source and report controls retain their names and keyboard/return behavior. Author visual observations are separate from automated layout assertions and the remaining independent review.

Type And Area

  • Bug fix / presentation refinement
  • Focused regression update
  • Public presentation surface
  • Shared-authority RFC fixture impact: N/A; no protocol, authority or provider behavior changed.

Boundary Checklist

  • Public-safe source, synthetic screenshots and body; private footage and raw diagnostics excluded.
  • No benchmark execution, merge, installation or release action.
  • Existing RFC pairs unchanged; bilingual diff check passed.
  • First viewport evidence embedded directly above.
  • DCO sign-off present.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; declaration_source=runtime_reported; reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

APPROVE — 完整阅读链与实际整页观察支持此布局切片。 精确 head 5039d53f90ab1060611608ce35ce5878b40a1dcf。

动机 / Motivation

在既有研究页阅读已存汇报、核对量化结果和原文证据的用户。原默认页面先铺指标、把汇报放在后面;修改后桌面左侧先读汇报、右侧并排核指标,窄屏先呈现汇报,展开深度内容时回到单列。打包真实 HTTP/SQLite 页面中,汇报、竞争解释、下一步、原生未知和引用返回均可读取,没有新增分析或 Agent 执行。本 PR 交付既有研究页的阅读布局,不重算分析、改原证据或新增生成流程;正式 App 安装采用和真实用户理解收益不在本次源码验收内。正式 App 采用、真实用户理解和原研究分析质量仍归既有产品交付工作;本次不据布局批准关闭这些整体要求。

改动思路 / Approach

复用原 GoalResearchHistory、analysis.location 和既有汇报/指标/引用组件;只改变同一数据的阅读次序与栅格,展开时让完整正文占一列,不添加同步状态或第二份数据 owner。当前 PR 边界是原研究页默认/展开/窄屏的完整阅读与返回链,可以整体回滚;后端事实、生成权限和安装采用继续由原 owner 负责。Doing nothing retains metrics-first order; a separate report page or new setting adds navigation. Reordering existing components with an adaptive grid is the smaller lawful fix. 普通任务是读取已有研究结果,无需再确认、重填已知信息或创建新分析。展开和原文是自愿阅读步骤,关闭返回当前证据入口。

具体改动 / Changes

11 个文件中只有两个生产布局文件、一个既有 browser fixture 和八张合成图片。报告与结果层调整顺序并复用原锚点;citation 按当前展开状态只放在一个位置,避免原文面板脱离阅读上下文。栅格按宽度适配,展开强制一列;没有改模型生成、native 读数、source binding、账户或执行权限。原有语义控件名、44px 按钮和正文尺寸保持。

关键代码讲解

  • GoalResearchHistory:研究页绑定原 Goal/source,组合汇报和指标。报告先行;location.open 为真时 citation 留在展开汇报区域。一个引用面板、精确入口回焦点;浏览不产生分析执行。
  • .research-reading-overview:按可用宽度排同一内容,不缩正文。auto-fit 最小 420px;展开为一列,24/40px 间距。窄屏自然单列,正文 16px;完整未知/失败仍保留。

规范依据:docs/development/design.md,修改前不可变 revision b69021498ef7483b1d2b190bc3f4c7bb6675c882。按原研究阅读任务判断,不把该切片扩成全站设计或新的生成质量义务。

  • Earn The User's Attention — implemented:Desktop/390 default and expanded manual observation, original citation return
  • Research Workspace / 研究工作台 — implemented:Complete canonical packaged scenario: analysisWrites=0, turnRequests=0; Ego source_unchanged=true/mutation_attempts=0
  • Populated Page Review — implemented:8 exact-head committed images inspected incl. long repeated/default/expanded/narrow/English; actual Ego desktop/390 reading and lower metrics; canonical HTTP recovery cases

对主干的风险 / Risks

最强反例是默认汇报看起来整洁,但展开后缩字号或把原文面板放到另一层导致丢失上下文。当前整页默认/展开、390 窄屏、原文返回及下方指标分别观察;未知保留、无效候选和竞争解释没有被清理掉。所有视觉证据均为明示的 synthetic 数据,不含私人会话或本机路径。

PASS:当前 chat build、259.630 秒完整 packaged research-history 场景、真实 Ego 阅读及原文返回。标准 premerge 的四项直接、13 项选中自动检查全部通过;返回值仍为 manual_review_required,因为八张二进制图需要人工核验。八图已逐一查看像素、来源和 PNG metadata,无文本/EXIF 隐藏块或私有操作内容;这是本次人工核验,不把原生 hold 改写为自动通过。初次浏览器运行因隔离 HOME 找不到既有 Playwright 失败,显式指向本机现有依赖后同场景/断言通过,历史失败保留。构建的大 chunk 提示也保留。

打包功能断言和人工视觉判断分列;没有用折叠、零横溢出或来源字段存在证明理解改善。 未查询、轮询或等待 CI。

语义与 CI 对齐

全 diff 未添加共享状态或新词表;原分析与来源 owner 保持,默认只读和明确生成权限没有变化。自动文本/语义检查和图片人工核验的边界分别保留;没有以当前布局清除任何历史科研或安装失败。

我的整体评价 / Verdict

APPROVE 此 bounded justified increment;long_horizon preserved、user_experience improved 限于实际打包阅读链,不外推到生成质量或安装效果。当前 PR 边界是原研究页默认/展开/窄屏的完整阅读与返回链,可以整体回滚;后端事实、生成权限和安装采用继续由原 owner 负责。 复用原组件与原状态的规模合适,单独引入设置、另一报告页面或抽象框架没有必要。兼容/数据 owner 不变,未发现当前阻塞性问题。

实际整页观察支持汇报先行、指标易比较和展开正文可读;桌面 1440×1000、390×844 默认/展开与引用往返,以及长重复汇报、英文和下方指标区均已看过。正式安装 App、真实用户理解速度、生成译文语义质量与全站可读性未验证;没有从合成截图推断这些结果。 8 张 binary hold 由本次像素/metadata/source 人工审查处理,原生 premerge 仍如实记录 manual_review_required。本结论不授予 merge、安装或其它受保护行为权限。

English verdict: APPROVE 5039d53; the report-first responsive reading and citation-return journey is validated; formal App adoption and comprehension gains remain unverified.

@huangruiteng
huangruiteng merged commit f205c02 into main Oct 28, 2026
33 of 45 checks passed
@huangruiteng
huangruiteng deleted the codex/research-reading-refinement-20261028 branch October 28, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants