Skip to content

test: fix canonical smoke clock and path determinism - #7507

Merged
loopx-agent merged 1 commit into
mainfrom
codex/pr7499-audit-repair-20261028
Oct 27, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/pr7499-audit-repair-20261028

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Fix the two remaining fixture defects from #7499's post-merge audit.

Status wrapper/direct parity now fixes both the collection clock and the ownership-observation adapter clock. A read crossing a wall-clock second no longer fails solely on observed_at; the full comparison of provider revision, freshness and other facts stays intact. Configure-goal resolves its temporary root before authoring the fixture, matching canonical import's physical project binding while retaining exact command assertions.

Only the two existing public synthetic smokes change. Their real saved import, SQLite reads, CLI configuration/quota journey, negative cases and independent orchestration assertions remain. No production behavior or UI changes. The bounded refactoring pass found no need for a new helper or consolidation of these separate integration contracts.

Validation at ebc398cc6472280976a2a15b1bfb78caa1a704d3:

  • Both full changed smokes passed; configure-goal also passed with an explicit symlinked temporary-directory root.
  • At the same main baseline, forced adjacent ownership-observation seconds and the explicit path alias reproduce the audit failures; the repaired scripts pass those cases.
  • Deliberate provider-revision, envelope-freshness and promotion-freshness mutations still fail the parity assertion.
  • 27 related status/coordination tests passed; Ruff, Python compile, bilingual diff, diff hygiene and the isolated two-file public-boundary scan passed.
  • Standard premerge passed: 5 direct checks, 10 catalog checks, 8 risk-profile checks and 1 public-boundary check; zero failures, timeouts, skips or manual holds. Exact-head self-review is published; merge readiness is checked separately immediately before merge. CI was not queried under the configured policy.

This qualifies the scoped synthetic regressions, without reusing the earlier head's 514-smoke result or claiming full release, installed-user, real-model or Lark delivery qualification.

Final quality qualification: receipt cqr_e8f3a9dc66eecc5adc22, fingerprint e8f3a9dc66eecc5adc22cc687a9500dabe560c8f5c1f16a99b569c134eefa445, two changed files; safe-fix allowed but not applied (0 additional passes), 0 blockers/warnings/advisories. Exact-scope verification is valid; the Goal-scoped standard premerge passed against verified main 1c4fa2b25a4723d2f58851a2a8bfb1b251e63cd1. An earlier stale-receipt hold after main advanced is retained and was requalified, with no test failure or bypass of the receipt gate.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; gpt-6.1-sol; OpenAI; runtime_reported; reasoning_effort=max
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

APPROVE,精确 head ebc398cc6472280976a2a15b1bfb78caa1a704d3。

动机 / Motivation

运行公开回归、准备发布资格的维护者。 旧脚本在两次读取跨秒时可能误报状态差异,并在临时目录使用路径别名时中断配置验证;修复后两条完整旅程均可执行到原有断言。 已复现旧版的两个失败,修复后普通及显式别名场景通过,provider revision 与 freshness 的真实差异仍触发失败。 本次只修复两个合成 smoke,不改变产品 authority、运行时默认或 UI,也不替代完整 release、真实模型和 Lark 交付资格。

改动思路 / Approach

在现有 fixture 边界修复:状态比较同时固定 collection 和 ownership adapter 的观测时钟,配置测试在创建源数据前确定 physical root。继续使用真实 saved import、SQLite 与 CLI;状态和权限仍由既有 typed owner 决定。删除时间字段、放宽完整命令比较或恢复 Markdown fallback 都会降低验证价值;当前方案没有这样做。两处短变更用文字即可说明,无需额外图示。

具体改动 / Changes

规范为 787f15e82283ae4cd590dc0ec91d88b09db4e122 的 docs/development/good-smokes.md。review-checklist:implemented,两次读取跨秒和显式路径别名不再决定语义测试成败;prefer-semantic-pressure:implemented,provider revision、envelope fresh、promotion freshness_status 三种 mutation 仍被拒绝;public-safe-fixtures:implemented,仅保留原有临时合成 fixture,公共边界扫描通过。

assert_wrapper_parity 新增第二个局部 clock patch,完整 payload equality 和独立编排断言保留。main 先 resolve 根目录,随后才 author fixture;原有 boundary、quota、interaction contract 的完整预期命令仍独立构造和比较。共两个测试文件 +13/-4,生产代码、文档、generated 和 UI 均未改动。

对主干的风险 / Risks

重点检查是否把真实差异一起隐藏。旧版普通 status 曾 PASS,但强制相邻秒会只在 ownership observed_at 失败;修复版通过同一探针,三个非时钟 mutation 仍 FAIL。旧版在显式 symlink TMPDIR 的完整 configure-goal 入口失败,修复版执行到末尾并 PASS,没有用实际输出覆盖 expected command。

PASS:两个完整 public smoke、额外显式路径别名场景、27 项相关 status/coordination 测试、Ruff、Python compile、双语 diff 和 whitespace。标准 premerge 的 10 catalog + 8 risk + 1 boundary 均通过;两文件 isolated public scan、规定 Ruff scope 和 17 文件 mypy 通过。

最终带 Goal 的标准 premerge 在固定主干 1c4fa2b25a4723d2f58851a2a8bfb1b251e63cd1 上通过:5 direct + 19 selected,0 failure/timeout/skip/manual hold;严格 CQR cqr_e8f3a9dc66eecc5adc22 已记录、原始凭证读回并验证 valid。最终 scope fingerprint 为 e8f3a9dc66eecc5adc22cc687a9500dabe560c8f5c1f16a99b569c134eefa445,2 文件;safe-fix allowed=true / applied=false / pass_count=0;blocker/warning/advisory 均为 0。首次带 Goal 的门禁正确拒绝了基线前移后过期的凭证;保留该 stale 结果,核对新增主干变化后重新 prepare/record/verify 并通过最终门禁,没有把旧 hold 改写为 PASS。私有 mutation 探针首次因 wrapper 的 imported alias 没有注入到目标调用,修正为实际 direct-read 边界后才取得有效反例;保留该失败记录。初次未隔离的检查涉及既有 registry 诊断,未当作本次修复范围或通过证据。CI 依已解析的 wait_for_ci=false 未查询。

已检查 #7499 的 audit 和相关 #7502、#7506、#7464,后者只处理 quota cache 的时钟,不替代本次两条现有旅程。近期同作者清单限 30 项,并非穷尽;没有新增重复 smoke 或一次性输出快照。原有大集成脚本仍有独立 CLI 覆盖,本次无须拆出框架。

我的整体评价 / Verdict

本次 scoped goal_achieved:两项 audit 缺口在原 owner 修复,完整语义断言未降低。long_horizon 与 user_experience 的产品契约 preserved,未增加用户准备或确认轮次。检查了两个 examples 脚本的完整 diff,未改动渲染代码或产品展示;visual review 不适用。 未验证范围:本次非视觉 diff 内无;完整发布、安装用户、真实模型与 Lark 交付仍在本任务之外。

局部整理已完成,不新增兼容分支、vocabulary、authority 或默认开关;现有 saved import 和 typed provider 继续复用。无需新的 helper 或强行合并两个不同不变量。没有剩余 blocking finding;精确 head、公开 review、approval closeout 与 merge readiness 仍分别执行,不继承旧 head 的 514 项结果。

English verdict: APPROVE ebc398cc6472280976a2a15b1bfb78caa1a704d3. Both audited smoke defects are fixed at their fixture owners; forced clock/path counterexamples, retained semantic mutations, 27 adjacent tests and all required local premerge checks pass. No production or UI behavior changes; full release qualification remains separate.

@loopx-agent
loopx-agent merged commit 4b87417 into main Oct 27, 2026
19 of 32 checks passed
@loopx-agent
loopx-agent deleted the codex/pr7499-audit-repair-20261028 branch October 27, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant