Skip to content

feat: support Teams dashboard image attachment via adaptive card - #662

Open
AbgarSim wants to merge 6 commits into
looker-open-source:masterfrom
AbgarSim:teams-image-attachments
Open

feat: support Teams dashboard image attachment via adaptive card#662
AbgarSim wants to merge 6 commits into
looker-open-source:masterfrom
AbgarSim:teams-image-attachments

Conversation

@AbgarSim

@AbgarSim AbgarSim commented Mar 28, 2025

Copy link
Copy Markdown

This PR adds the possibility to attach images to the generated Teams message, this is achived by using AdaptiveCard instead of MessageCard

@AbgarSim
AbgarSim marked this pull request as ready for review May 7, 2025 07:15
@AbgarSim
AbgarSim requested a review from a team as a code owner May 7, 2025 07:15
@phillipperalez
phillipperalez self-requested a review May 15, 2025 15:47
@phillipperalez

Copy link
Copy Markdown
Contributor

Make sure to make the change in the .ts file, then run yarn build and it will generate the js. This looks fine once that is done, however this will change the behavior. Could you send me a screenshot of what it will look like after the change in a comment too?

@AbgarSim
AbgarSim force-pushed the teams-image-attachments branch 3 times, most recently from 600bb51 to a2a79fb Compare May 20, 2025 12:57
@AbgarSim
AbgarSim force-pushed the teams-image-attachments branch from a2a79fb to 5eced81 Compare May 21, 2025 20:07
@AbgarSim

AbgarSim commented May 21, 2025

Copy link
Copy Markdown
Author

Make sure to make the change in the .ts file, then run yarn build and it will generate the js. This looks fine once that is done, however this will change the behavior. Could you send me a screenshot of what it will look like after the change in a comment too?

@phillipperalez

  • Updated both the .ts file and regenerated the .js by running yarn build.
  • Also attached a screenshot showing how the Teams message looks with the updated Adaptive Card and embedded dashboard image.

Screenshot 2025-05-21 at 23 06 56

Let me know if you’d like any changes to the layout or formatting before merging.

@air720boarder

Copy link
Copy Markdown

Will this get fixed or revisited?

@AbgarSim

Copy link
Copy Markdown
Author

@phillipperalez any plans to review/potenitaly merge this? I can keep rebasing but the branch will always be out of date if noone revisits this

@AbgarSim

Copy link
Copy Markdown
Author

In case anyone visits this PR let me know and I will rebase/squash changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants