Repository navigation
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
===========================================
+ Coverage 7.59% 22.71% +15.11%
===========================================
Files 57 63 +6
Lines 4462 6163 +1701
===========================================
+ Hits 339 1400 +1061
- Misses 4123 4763 +640
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
derekbit
force-pushed
the
memory-diag
branch
from
November 19, 2026 04:11
ab180f0 to
53d0f2a
Compare
Restructure `longhornctl diagnose` into a `<verb> <noun>` command group consistent with other `longhornctl` commands: - `longhornctl diagnose system`: moves the existing Kubernetes and Longhorn control-plane, CSI, instance-manager, and volume health checks under the `system` subcommand. - `longhornctl diagnose v2-data-engine` (and `longhornctl-local diagnose v2-data-engine`): inspects live V2 Data Engine `spdk_tgt` processes across nodes via a temporary read-only DaemonSet without pausing the SPDK reactor. `diagnose v2-data-engine` combines non-blocking SPDK JSON-RPC queries with ELF/DWARF-guided `/proc/<pid>/mem` inspection to collect and correlate: - Global `iobuf` pool capacities, live DPDK `rte_ring` free counts, per-thread wait queues, and per-module lockless caches. - Shared `blobstore` and per-blob `spdk_bs_channel` request-set pools (`freeReqs`, per-lvol `need_cluster_alloc` queues, and in-flight `cluster_cow` / `esnap_cow` operations). - Queued `bdev` `nomem_io` requests (resolved to Longhorn lvol names) and active `bdev_no_mem_poller` counts. - Cross-node NVMe-oF external snapshot read dependencies, transitive stall propagation, and distributed deadlock cycles. Results support `-o yaml` (default), `-o json`, and `-o text`. YAML and JSON outputs surface the synthesized cluster summary, deadlock cycles, and cross-node dependencies ahead of the full raw per-node forensic data, and the command exits with a non-zero status after DaemonSet cleanup if any SPDK target is stalled or deadlocked. longhorn/longhorn#14589 Signed-off-by: Derek Su <derek.su@suse.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
derekbit
force-pushed
the
memory-diag
branch
from
November 19, 2026 05:40
53d0f2a to
576fb2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#14589
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context