Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions benchmarks/aggregate_gpui_shell.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,16 @@ def main() -> None:
"automatic": select(samples(directory, "panel", "automatic"), lifecycle_keys),
},
}
for workload, name, suitable, regression_guard in (
("panel", "realistic 443-node host-heavy panel", False, True),
("compute", "render-driven numeric layout checksum", True, False),
for workload, name, suitable, regression_guard, native_required in (
("panel", "realistic 443-node host-heavy panel", False, True, False),
("compute", "render-driven numeric layout checksum", True, False, True),
("mixed", "market compute, sort, aggregate, and visible list", False, False, True),
):
document["workloads"].append({
"name": name,
"suitable_for_jit": suitable,
"regression_guard": regression_guard,
"native_required": native_required,
"interpreter": select(samples(directory, workload, "interpreter"), workload_keys),
"automatic": select(samples(directory, workload, "automatic"), workload_keys),
})
Expand Down
31 changes: 30 additions & 1 deletion benchmarks/gpui_shell_report.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ struct Workload {
name: String,
suitable_for_jit: bool,
regression_guard: bool,
#[serde(default)]
native_required: bool,
interpreter: Vec<Sample>,
automatic: Vec<Sample>,
}
Expand Down Expand Up @@ -182,11 +184,12 @@ fn validate_and_render(report: &Report) -> Result<(String, bool), String> {
.iter()
.map(|x| x.fallback_count)
.sum::<u64>();
let native_gate = !workload.native_required || every_sample_native;
let suitable_gate = !workload.suitable_for_jit
|| (speedup[0] + f64::EPSILON * 8.0 >= 2.0 && every_sample_native);
let regression_gate = !workload.regression_guard
|| (speedup[0] + f64::EPSILON * 8.0 >= 1.0 / 1.05 && tail[1] <= 1.05);
let pass = suitable_gate && regression_gate;
let pass = native_gate && suitable_gate && regression_gate;
workloads_pass &= pass;
if workload.suitable_for_jit {
suitable += 1;
Expand Down Expand Up @@ -417,6 +420,7 @@ mod tests {
name: "real panel".into(),
suitable_for_jit: true,
regression_guard: true,
native_required: false,
interpreter: samples(100 * speedup, false, 0),
automatic: samples(100, true, automatic_native_entries),
}],
Expand Down Expand Up @@ -511,4 +515,29 @@ mod tests {
assert!(markdown.contains("host panel"));
assert!(markdown.contains("Overall: **FAIL**"));
}

#[test]
fn observational_mixed_workload_requires_native_without_a_speed_gate() {
let mut report = report(2, 1);
let mut mixed = report.workloads[0].clone();
mixed.name = "mixed market panel".into();
mixed.suitable_for_jit = false;
mixed.regression_guard = false;
mixed.native_required = true;
mixed
.interpreter
.iter_mut()
.for_each(|sample| sample.steady_state_ns = 100);
report.workloads.push(mixed);

let (markdown, pass) = validate_and_render(&report).unwrap();
assert!(pass, "{markdown}");

report.workloads[1]
.automatic
.iter_mut()
.for_each(|sample| sample.native_entries = 0);
let (markdown, pass) = validate_and_render(&report).unwrap();
assert!(!pass, "{markdown}");
}
}
Loading
Loading