Repository navigation
chore: help record types and one prototype header per folder - #272
Merged
Merged
Conversation
Decompilation progress
No function changed its match state compared with main (9071100). Compared with main (9071100). C_FUZZY uses main's last measurement. |
Consolidate evidence-backed help state and message layouts, name tutorial record fields, and propagate usage time-bucket names across callers. Preserve signed views, assembler labels and register-live calls. Local draft: cleanup checks, 102 Linux tests, EE layouts and resumed full boot retail gate pass. All 62 edited overlay units compile; 59 normalized assembly outputs match and the three type-size declaration changes pass focused retail proof across 59 placements. Full overlays remain blocked by Ps2EeAs crashing on unchanged burning_debris input. No aggregate overlay qualification or native integration claimed.
Treat PR #270 as authoritative for HelpState, field and local names, prototype headers and repository layout. Remove the duplicate window type and retain compatible message-entry, usage/history field and layout-check improvements.
The single-function headers from the extern move become one header per source folder (src/audio/decoder/*.c -> include/rnc/audio/decoder.h). Headers whose prototype differs from a caller's local declaration, or whose name a level copy also uses, keep their own file.
nickyyOO
force-pushed
the
chore/human-first-layout
branch
from
November 1, 2026 07:01
2e93c30 to
63f9f1c
Compare
nickyyOO
marked this pull request as ready for review
November 1, 2026 07:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The help window and tutorial records were read through loose offsets, and the extern move in #270 left 992 headers that hold one prototype each (one per function file), so a caller of three decoder functions included three headers.
After
src/check/help_window_layout_check.canddocs/game/help-messages.md.src/audio/decoder/*.c→include/rnc/audio/decoder.h(152 folder headers instead of 967 files; 531 files include fewer headers). Type headers are unchanged.blarg_helicopter_update,gadgebot_update,update_moby_suck_cannon_statein l12/l18 class tables).src/camera/update_camera.ccallsupdate_all_camerasthrough its header instead of thefunc_001EC420alias (same address).Verification
make elfends withPASS: reconstructed boot ELF matches retailmake overlaysends withPASS; all 1992 overlay objects compare equal to the build before the header changemake checkpasses (test_public_tools OK, check-cleanup: no new problems)-fsyntax-only(with and without-DNON_MATCHING) gains no undeclared, conflicting, asm-label or redefinition errors in anysrc/filescripts/format.py --check