Repository navigation
[Agent Chat feedback] - Step 5: Report an error from the chat's More menu - #3616
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8806c77669
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| : undefined | ||
| } | ||
| onSetChatBookmarked={handleSetActiveChatBookmarked} | ||
| onReportError={handleReportError} |
There was a problem hiding this comment.
When the active session has no user-visible messages, isLanding is true and AgentHome skips AgentChatControls entirely, so this callback is not reachable until after the first message. That breaks the newly specified “even before any message” behavior and prevents reporting startup or empty-session failures from the chat menu; the current component test misses this because it renders the controls directly rather than through AgentHome. Render a reachable report action for the landing state as well.
AGENTS.md reference: AGENTS.md:L27-L27
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not changing this; it's intentional. Report error belongs to a chat that has messages, which is when the More Actions bar appears. A backend that fails before the first message shows the session error card at the top of the chat view, and that card should get its own report action. The test name and PR description no longer claim the item works before a message (02905d1).
| Save chat as note | ||
| </DropdownMenuItem> | ||
| )} | ||
| {onReportError && ( |
There was a problem hiding this comment.
This new conditional rendering branch and its corresponding it("reports an error…") case carry no originating GitHub issue URL. That leaves the reason and intended lifetime of the branch untraceable and violates the repository's landing requirement for every new behavioral branch; add the full issue URL to both a nearby why-comment and the test description.
AGENTS.md reference: AGENTS.md:L28-L28
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in b19fe31: the guard has a why-comment linking https://github.com/Brevilabs/obsidian-copilot-private/issues/672, and the test name carries the same URL.
b823c86 to
c078242
Compare
46c1833 to
f64e6d3
Compare
ae48e14 to
6064e81
Compare
f64e6d3 to
7c2c3bc
Compare
e49660e to
2136f06
Compare
Report error opens Report an issue for the open chat without going through Settings: it screenshots that chat's pane, ticks every attachment, and ends the description with the chat's backend, model and session. The evidence line now comes from one session helper shared with the feedback card. Relates to Brevilabs/obsidian-copilot-private#672 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7c2c3bc to
846cace
Compare
The More Actions bar appears only once a chat has a message, so the item is never reachable before one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Relates to Brevilabs/obsidian-copilot-private#672
Why
When something goes wrong in an Agent Chat, a user who wants to tell us has two paths today. One is the feedback card, which appears only if the agent decides to raise it. The other is Settings → Advanced → Debugging & support → Report an issue, which means leaving the chat, finding the button, and writing up from memory which agent, model, and chat it was. Most users see the problem in the chat and give up before reaching Settings. The chat already has a More Actions (⋯) menu above the composer, so that is where a report should start.
What
More Actions gains a Report error item. It opens the same Report an issue dialog, set up for the chat it came from:
Evidence: backend … · model … · session … · <time>The item appears once the chat has a message, since the More Actions bar is part of the conversation view; it stays available when the reply fails. Upload, redaction, and the report ID flow are unchanged.
Non goal
Screenshot
Choosing Report error opens the dialog prefilled for this chat:
Risk
Medium
AgentChatControls,getReportEvidenceandformatChatReportNotetests cover the menu item, the evidence and the note, but the click handler that opens the dialog from the chat cannot be covered by an automated test becauseAgentHomeneeds a live Obsidian workspace and agent sessionReview: read
handleReportErrorinsrc/agentMode/ui/AgentHome.tsxandgetReportEvidenceinsrc/agentMode/session/AgentSession.ts, then run Verification steps 2-3.Verification
Evidence:line naming this chat's agent, model, and session. Every attachment is ticked.