Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_2dblended the small-scale rms/mean maps intoout_rms2/out_mean2in place, one bright source at a time. With overlapping bounding boxes, later sources read already-blended values, so the result depended on the order of the sources.Fix
Keep a copy of the large-scale maps, collect the small-scale weights of all sources into one
weights_map(maximum where boxes overlap), and blend once.Now the local rms/mean near a bright source should reflect the source and its artifacts, not the order in which sources happen to be listed, which has no physical meaning.