Skip to content

Fix omitted highest order terms in shapelet reconstruction - #543

Open
AlexKurek wants to merge 5 commits into
lofar-astron:masterfrom
AlexKurek:Fix-omitted-highest-order-terms-in-shapelet-reconstruction
Open

AlexKurek wants to merge 5 commits into
lofar-astron:masterfrom
AlexKurek:Fix-omitted-highest-order-terms-in-shapelet-reconstruction

Conversation

@AlexKurek

Copy link
Copy Markdown
Contributor

Iterate over all coefficient indices with i + j <= nmax, matching the index range used when decomposing the image. The previous bounds omitted the highest total order and reconstructed no terms for nmax=0.

@gmloose

gmloose commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

This may indeed be a bug fix. @darafferty, what do you think?

However, using nmax=0 will still raise an IndexError in

hnm1[0]=1.0; hn[0]=0.0; hn[1]=2.0

because the hn will have length 1 in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants