Repository navigation
fix(read-text): align read limits, guidance, and output previews - #63
Merged
Merged
Conversation
Avoid unnecessary small read windows and repeated reads while keeping successful file output subject to the configured TUI display policy. - Raise the default and maximum read window to 2,000 lines while retaining the independent 1 MiB scan/return limit. - Consolidate task-sized read and content-reuse guidance in the stable coding policy; keep tool mechanics in the tool description. - Share render-time preview visibility and truncation for process and file output, bounding previews to five lines of 180 Unicode scalars each. - Let unset Python workspace limits inherit Rust defaults through Option values; preserve explicit overrides and document the None-valued fields. - Cover live/replayed output, failure visibility, long UTF-8 lines, native limit enforcement, invalid limits, and failure-before-write behavior. Verification: cargo fmt --all --check; cargo clippy --all-targets --all-features -- -D warnings; cargo test --all (2,219 passed, 9 ignored). Python: uv sync, native test-utils build, Ruff format/check, ty check, pytest (78 passed), and uv build. git diff --check passed. Prompt, tool-description, and default-schema changes affect cross-version prefix reuse; instructions and tool order remain stable within a session.
10 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_textoutput honorshow_successful_command_outputin both live sessions and transcript replay, without hiding failure diagnostics or changing runtime artifacts/model-visible results.Boundaries and compatibility
WorkspaceLimitsfields now remainNonewhen inherited. Explicit positive values still override individual Rust defaults; Python configuration is not a resolved-default snapshot. SDK documentation and native type stubs are updated.Verification
git diff --checkcargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all— 2,219 passed, 9 ignoreduv syncandmaturin develop --uv --features test-utilsty check— zero diagnosticspytest tests -q— 78 passeduv build— source distribution and wheel built successfullyLong-line preview regression tests fail before the preview bound is restored and pass afterward. Python limit tests use a local deterministic model fixture and execute the actual Rust workspace tools. No live-model comparison is claimed for the prompt's behavioral effects. Packaging still reports existing Cargo manifest metadata warnings.