Conversation
- msgfmt excludes fuzzy entries from the compiled catalog, so a stale `#, fuzzy` on an entry we translated made the app fall back to the source string - Existing-file write-back: record the entry being translated by its own key when each change is registered, then rewrite its `#,` lines, walking backwards so a removed line cannot shift an unvisited one - New-file creation: strip fuzzy once after all plural forms are in, so the outcome does not depend on their order - Other flags on the same line and the `#|` previous-msgid block are left as found - Regression tests for each path, each shape of plural key, several flag lines per entry, and the plural-form ordering cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#, fuzzyon an entry we translated made the app fall back to the source string#,lines, walking backwards so a removed line cannot shift an unvisited one#|previous-msgid block are left as found