This repository was archived by the owner on Jun 4, 2026. It is now read-only.
Fix regression bug with notification type enqueuing as separate notification#138
Merged
Conversation
Merged
Member
|
Added a separate issue for the ESLint failures: #139 |
finnlewis
approved these changes
May 27, 2025
finnlewis
left a comment
finnlewis
left a comment
Member
There was a problem hiding this comment.
Tests pass, (apart from for PHP 8.4)
Adnan-cds
reviewed
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
What does this change?
Enqueues notifications depending on service contact and notification type, not just on service contact
With #134 a fix was committed that ensures email notifications were aggregated, but this exposed another error. A notification type is designed to use it's own email template and so needs to be enqueued separately. This happened previously as notifications weren't aggregated, now they are they are not separated by type.
How to test
There's only one notification type currently defined, so as long as the tests pass I think it's good to merge 😄