Skip to content

fix: only chmod files owned by deploy user in shared storage #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loadinglucian merged 1 commit into from
Feb 25, 2026
Merged

fix: only chmod files owned by deploy user in shared storage #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .deployer/scripts/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,19 @@ set -euo pipefail

set_group_writable_tree() {
local path="$1"
local current_user

if [[ ! -d "${path}" ]]; then
return
fi

# Keep shared writable trees group-writable and SGID so new entries inherit group.
find "${path}" -type d -exec chmod 2775 {} +
find "${path}" -type f -exec chmod 664 {} +
current_user="$(id -un)"

# chmod can only be performed by file owner (or root). During runtime some
# cache files may be owned by www-data, so normalize only deployer-owned
# entries and do not fail deployment if skipped files exist.
find "${path}" -type d -user "${current_user}" -exec chmod 2775 {} + 2> /dev/null || true
find "${path}" -type f -user "${current_user}" -exec chmod 664 {} + 2> /dev/null || true
}

# ----
Expand All @@ -69,7 +74,6 @@ if [[ $framework == "laravel" ]]; then
echo "→ Ensuring shared storage directories..."
mkdir -p "${DEPLOYER_SHARED_PATH}/storage/"{app,framework,logs}
mkdir -p "${DEPLOYER_SHARED_PATH}/storage/framework/"{cache,sessions,views}
mkdir -p "${DEPLOYER_SHARED_PATH}/storage/framework/cache/docs-output/.locks"

# Make shared storage writable for both deploy user and PHP-FPM group member:
set_group_writable_tree "${DEPLOYER_SHARED_PATH}/storage"
Expand Down Expand Up @@ -164,7 +168,6 @@ if [[ $framework == "laravel" ]]; then
echo "→ Optimizing..."
"${DEPLOYER_PHP}" artisan optimize:clear
"${DEPLOYER_PHP}" artisan optimize
"${DEPLOYER_PHP}" artisan docs:clear

# Artisan commands can create new cache/session/log paths. Re-apply permissions
# to keep shared storage writable for both deploy user and PHP-FPM group member:
Expand Down