fix: move footer inside main content column - #28
Conversation
Relocate the footer from below the three-column grid into the <main> content area so it aligns with documentation text width.
📝 WalkthroughWalkthroughThe footer block in the docs layout template is repositioned from after the right sidebar to within the main content section, placed immediately after the slot element. This structural reorganization maintains approximately equal lines of code with a balanced addition and removal. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/views/components/layouts/docs.blade.php (1)
79-110: Footer relocation looks good; consider using Flux icon for the heart.The structural change correctly places the footer inside the main content column, achieving the intended width constraint. Accessibility is well handled with
aria-label,sr-only, andrel="noopener"on external links.For consistency, consider replacing the inline SVG heart with
<flux:icon.heart />, which matches the pattern used for social icons and is available in Flux UI's Heroicons icon set.♻️ Suggested refactor for icon consistency
<p> <span>Made with tender love</span> - <svg class="inline-flex shrink-0 text-zinc-400 [:where(&)]:size-4" data-flux-icon="" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="currentColor" aria-hidden="true" data-slot="icon"> - <path d="M2 6.342a3.375 3.375 0 0 1 6-2.088 3.375 3.375 0 0 1 5.997 2.26c-.063 2.134-1.618 3.76-2.955 4.784a14.437 14.437 0 0 1-2.676 1.61c-.02.01-.038.017-.05.022l-.014.006-.004.002h-.002a.75.75 0 0 1-.592.001h-.002l-.004-.003-.015-.006a5.528 5.528 0 0 1-.232-.107 14.395 14.395 0 0 1-2.535-1.557C3.564 10.22 1.999 8.558 1.999 6.38L2 6.342Z"></path> - </svg> + <flux:icon.heart class="inline-flex size-4 shrink-0 text-zinc-400" /> <span>and care</span>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/views/components/layouts/docs.blade.php` around lines 79 - 110, Replace the inline heart SVG with the Flux icon component to keep icon usage consistent: locate the inline <svg ... data-slot="icon"> heart in the footer and swap it for <flux:icon.heart /> (preserving the existing classes/aria-hidden styling such as class="inline-flex shrink-0 text-zinc-400 [:where(&)]:size-4" and aria-hidden="true" so visual appearance and accessibility remain unchanged).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/views/components/layouts/docs.blade.php`:
- Around line 79-110: Replace the inline heart SVG with the Flux icon component
to keep icon usage consistent: locate the inline <svg ... data-slot="icon">
heart in the footer and swap it for <flux:icon.heart /> (preserving the existing
classes/aria-hidden styling such as class="inline-flex shrink-0 text-zinc-400
[:where(&)]:size-4" and aria-hidden="true" so visual appearance and
accessibility remain unchanged).
Relocate the footer from below the three-column grid into the
<main>content area so it aligns with the documentation text width (lg:max-w-[720px]) rather than spanning the full viewport.