Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpers.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from datetime import datetime, timezone

import httpx
from lnbits.core.services import get_pr_from_lnurl, pay_invoice
from lnbits.utils.safe_http import SafeHttpClient

from .crud import (
get_all_unpaid_players,
Expand All @@ -12,7 +12,7 @@


async def get_latest_block(mempool: str):
async with httpx.AsyncClient() as client:
async with SafeHttpClient() as client:
response = await client.get(f"{mempool}/api/blocks")
assert response.status_code == 200
return response.json()[0]
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ requires-python = ">=3.10,<3.14"
description = "LNbits, free and open-source Lightning wallet and accounts system."
authors = [{ name = "Alan Bits", email = "alan@lnbits.com" }]
urls = { Homepage = "https://lnbits.com", Repository = "https://github.com/lnbits/numberlottery" }
dependencies = [ "lnbits>=1.7.0rc1" ]
dependencies = [ "lnbits==1.7.0rc2" ]

[dependency-groups]
dev = [
Expand Down
98 changes: 98 additions & 0 deletions tests/test_lnurl_security.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
import json
from datetime import datetime, timedelta
from ipaddress import ip_address
from types import SimpleNamespace
from unittest.mock import AsyncMock

import pytest
from lnbits.core.services import lnurl as core_lnurl
from lnbits.settings import settings
from starlette.exceptions import HTTPException

from .. import views_api as views


@pytest.fixture
def anyio_backend():
return "asyncio"


@pytest.fixture
def game_route(monkeypatch):
payment = SimpleNamespace(payment_hash="payment-hash", bolt11="invoice")
create = AsyncMock(return_value=payment)
monkeypatch.setattr(views, "create_invoice", create)
monkeypatch.setattr(settings, "lnbits_callback_url_rules", [])
monkeypatch.setattr(settings, "lnbits_lnurl_allow_private_ips", False)
monkeypatch.setattr(
views,
"get_game",
AsyncMock(
return_value=SimpleNamespace(
completed=False,
closing_date=datetime.now() + timedelta(hours=2),
buy_in_max=100,
odds=10,
wallet="wallet",
name="game",
)
),
)
data = SimpleNamespace(
game_id="game", ln_address="alice@pay.example", buy_in=21, block_number=5
)
route = views.api_create_player
return route, data, create


@pytest.mark.anyio
async def test_private_lnurl_rejected_before_invoice(game_route, monkeypatch):
route, data, create = game_route
assert views.lnurl_handle is core_lnurl.handle
monkeypatch.setattr(
core_lnurl,
"_resolve_lnurl_host",
AsyncMock(return_value=[ip_address("127.0.0.1")]),
)
send = AsyncMock()
monkeypatch.setattr(core_lnurl, "_send_lnurl_request", send)
with pytest.raises(HTTPException) as exc:
await route(data)
assert exc.value.status_code == 400
create.assert_not_awaited()
send.assert_not_awaited()


@pytest.mark.anyio
async def test_public_lnurl_preserves_invoice_amount_wallet_and_metadata(
game_route, monkeypatch
):
route, data, create = game_route
monkeypatch.setattr(
core_lnurl,
"_resolve_lnurl_host",
AsyncMock(return_value=[ip_address("93.184.216.34")]),
)
response = {
"tag": "payRequest",
"callback": "https://pay.example/callback",
"minSendable": 1000,
"maxSendable": 100000000,
"metadata": '[["text/plain","Test payment"]]',
}
monkeypatch.setattr(
core_lnurl,
"_send_lnurl_request",
AsyncMock(return_value=(200, {}, json.dumps(response).encode())),
)
result = await route(data)
assert result == {"payment_hash": "payment-hash", "payment_request": "invoice"}
args = create.await_args.kwargs
assert args["wallet_id"] == "wallet"
assert args["amount"] == 21
assert args["extra"] == {
"tag": "numberlottery",
"ln_address": data.ln_address,
"game_id": "game",
"block_number": 5,
}
8 changes: 4 additions & 4 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion views_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
from lnbits.core.crud import get_user
from lnbits.core.models import WalletTypeInfo
from lnbits.core.services import create_invoice
from lnbits.core.services.lnurl import handle as lnurl_handle
from lnbits.decorators import require_admin_key
from lnurl import LnurlPayResponse
from lnurl import handle as lnurl_handle
from starlette.exceptions import HTTPException

from .crud import (
Expand Down
Loading