Repository navigation
fix: Changing Team Members vue file name - #8
Merged
Merged
Conversation
Closed
|
Deployed 1c9812e to https://pr-8.tirtest.com |
markcrivera
requested changes
Oct 16, 2026
markcrivera
left a comment
markcrivera
left a comment
Collaborator
There was a problem hiding this comment.
Suggested fix:
- rename the file to pages/administration/team-members.vue (no brackets)
- drop the AdminSidebar change, since the url then stays /administration/team-members and matches the kebab-case used by every other page
Also, we are trying to use Conventional Commits for semantic-release, so a commit/PR title like "fix(pages): make the team members page a static route" would be ideal.
|
Deployed b75e25b to https://pr-8.tirtest.com |
JeremyDGreene
changed the title
JeremyDGreene
changed the title
markcrivera
approved these changes
Oct 23, 2026
markcrivera
left a comment
markcrivera
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thank You.
|
Deployed b75e25b to https://pr-8.tirtest.com |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR gets rid of the WARNing message when first starting npm run due to a naming convention of an included page file.
Changes
Testing
I ran npm run dev and the warning message was gone, also verified login and other pages worked
Related
Closes #7