Skip to content

fix(login): correct username label association and autocomplete - #25

Open
kevjablonski wants to merge 1 commit into
mainfrom
fix/24-login-username-label-accessibility
Open

kevjablonski wants to merge 1 commit into
mainfrom
fix/24-login-username-label-accessibility

Conversation

@kevjablonski

Copy link
Copy Markdown

Summary

Fixes the username input's label association and autocomplete attribute in the login form to improve accessibility and browser autofill support.

Changes

  • Updated the username input's id from text to username to correctly associate it with its label.
  • Changed the input's name from text to username for consistency.
  • Corrected the autocomplete attribute from text to username to support browser autofill and password managers.
  • Updated the Playwright E2E login fixture to use getByLabel() for both username and password fields instead of CSS selectors.

Testing

  • Manually verified clicking the Username label focuses the correct input.
  • Verified login functionality remains unchanged.

Related

closes #24

Signed-off-by: Kevin Jablonski <kevjablonski@gmail.com>
@github-actions

Copy link
Copy Markdown

Deployed b978496 to https://pr-25.tirtest.com

This branch was successfully deployed

1 active deployment
review — b978496e Deployed Oct 26, 2026 by kevjablonski via test #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login form Username label is not associated with its input

1 participant