Open
Conversation
Doing some safer ones (npm audit fix & some manual overrides). Reduced total vulnerabilities flagged from 160 to 90 (9 low, 44 moderate, 11 high, 26 critical).
Contributor
|
I'm concerned about the CSS changes, this is modifying a bunch of color which I don't follow why? Did you check the newly built site? |
Member
Author
|
It is funny yes, I wouldn't expect that either. These are apparently from compiling the .scss source files using node-sass and postcss (with autoprefixer). upstream (mlir.llvm.org) 
without css changes 
with 
Now disclaimer: this was with newer version of Hugo (which required some other changes) that I tried. That shouldn't affect this. If you want, I can also split this in 2, one just dep bumps and we see if css changes are needed "live" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some safer ones (npm audit fix & some manual overrides).
Reduced total vulnerabilities flagged from 160 to 90 (9 low, 44 moderate, 11 high, 26 critical).
CSS changed due to
npm run build.