Repository navigation
Conversation
Brings the tagged release merge commit into develop to keep branch ancestry aligned.
Start v1.2.1 development
Add scriv based changelogs Add contributing guide Back port recent release notes to new changelog Add what's new section to docs with auto generated changelog and contributing guide
This PR partially addresses #476 Signed-off-by: Alan Thomas Grier <grier1@llnl.gov>
* Match parameter tokens exactly in get_used_parameters
_get_used_parameters built the search pattern as
r"\{}\({}\.*\w*\)".format(token, key), where \.* is zero-or-more
literal dots and \w* is zero-or-more word characters. For a parameter
named N that regex also matches $(NP), so a step whose command uses
only $(NP) reports both N and NP as used.
get_used_parameters feeds Study.get_tasks_per_step, which uses the
result to decide whether a step is expanded across parameter
combinations and to build the combination workspace/label. So a
prefix collision (common in HPC specs: N vs NP, X vs X2) can attach
the wrong parameters to a step or, when a command literally contains a
$(N...)-shaped token, expand a step into extra instances.
Require the character after the key to be ")" or ".<suffix>", and
re.escape the key. Exact, $(key.label), and $(key.name) forms still
match. Added a regression test.
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
* Tick dev version and add a changelog fragment
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
---------
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Extends hypothesis deadlines in CI only to account for increased system variability in CI environments.
Finalize 1.2.1 Version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge 1.2.1 into main for release/tagging