Repository navigation
Conversation
This was referenced Oct 26, 2026
ebchin
force-pushed
the
feature/ebchin/interface-quadrature
branch
from
October 27, 2026 05:58
035919f to
7139502
Compare
Member
Author
|
Deferring this work for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds owning interface quadrature data with the parent dimension stored at runtime. Each interface pair has a range of quadrature points, with parent coordinates on both meshes and physical integration weights.
Typed views expose fixed-size coordinate spans for element kernels without copying the stored coordinates. The data container can use host or device memory and does not retain mesh views or geometry derivatives.
Tests cover runtime dimensions, pair/point ranges, empty and moved data, adopted arrays, shape/offset checks, basis integration, and basis evaluation through typed views on each enabled execution backend.
Validation: the quadrature suite passed in Debug with LLVM 19.1.7, sequential and OpenMP execution, and Enzyme disabled. GPU cases could not be run locally and remain for CI.
Replaces #274. Depends on #276; followed by #278.