Repository navigation
Conversation
chapman39
requested review from
ebchin,
srwopschall and
white238
and
a balanced review from Copilot
October 15, 2026 21:02
chapman39
marked this pull request as ready for review
October 15, 2026 21:02
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
What changed in this PR
Updates Tribol’s CMake packaging to avoid exporting MFEM (and other non-Tribol) targets, reducing downstream target/export-set conflicts and forcing consumers to find their own third‑party deps.
Changes:
- Stop marking MFEM as
EXPORTABLEand remove logic that installs/exports MFEM (and Axom-provided targets) intotribol-targets. - Adjust
tribol-config.cmake.into import MFEM when it wasn’t built with CMake, instead of relying on exported targets. - Update MFEM/Axom target lists used for post-processing (e.g., Apple rpath workaround).
| File | Description |
|---|---|
| cmake/tribol-config.cmake.in | Stops relying on exported MFEM targets; imports MFEM when not CMake-built. |
| cmake/thirdparty/SetupMFEM.cmake | Prevents MFEM target from being added to Tribol’s export set. |
| cmake/SetupThirdParty.cmake | Removes installation/export of Axom/MFEM targets and adjusts MFEM target handling lists. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| blt_import_library( NAME mfem | ||
| INCLUDES "@MFEM_INCLUDE_DIRS@" | ||
| TREAT_INCLUDES_AS_SYSTEM ON | ||
| DEPENDS_ON "@MFEM_LIBRARIES@") |
Copilot stopped reviewing on behalf of
chapman39 due to an error
October 15, 2026 21:47
ebchin
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid exporting MFEM. this creates a lot of issues for downstream users. instead, each project will import the third party libraries they need individually.
related PR:
llnl/axom#2013