Skip to content

Add "tunings" Command Line Option - #333

Closed
michaelmckinsey1 wants to merge 18 commits into
llnl:developfrom
michaelmckinsey1:feature/MichaelMcKinsey1/tunings-arg
Closed

Add "tunings" Command Line Option#333
michaelmckinsey1 wants to merge 18 commits into
llnl:developfrom
michaelmckinsey1:feature/MichaelMcKinsey1/tunings-arg

Conversation

@michaelmckinsey1

@michaelmckinsey1 michaelmckinsey1 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Add "tunings" Command Line Option

  • This PR is a feature.
  • It does the following:
    • Modifies the parser to accept "-t" or "--tunings" as a command line argument which allows the user to specify which tunings to run. If the argument is not provided it runs all tuning which follows the current behavior.
      • Ex: Instead of
      Base_CUDA-default
      Base_CUDA-block_128
      Base_CUDA-cub
      Base_CUDA-library
      
      we can add --tunings default block_128
      Base_CUDA-default
      Base_CUDA-block_128
      
    • This feature is at the request of the PAVE team.

Comment thread src/common/Executor.cpp Outdated
Comment thread src/common/KernelBase.hpp Outdated
Comment thread src/common/RunParams.cpp
Comment thread src/common/Executor.cpp Outdated
@michaelmckinsey1
michaelmckinsey1 marked this pull request as ready for review June 14, 2023 18:05
Comment thread src/common/Executor.cpp Outdated
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
Comment thread src/common/Executor.cpp Outdated
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
Comment thread src/common/Executor.cpp Outdated
Comment thread src/common/Executor.cpp
Comment thread src/common/Executor.cpp
Comment thread src/common/Executor.cpp Outdated
@MrBurmark
MrBurmark requested a review from rhornung67 June 21, 2023 17:52
@rhornung67

Copy link
Copy Markdown
Member

@MrBurmark i sent you a teams chat message about this. we need to pull the branch from the fork into the repo and make a companion PR so Gitlab CI will run on it.

@rhornung67 rhornung67 mentioned this pull request Jul 10, 2023
24 tasks
@rhornung67

Copy link
Copy Markdown
Member

@michaelmckinsey1 I merged the companion PR to this one. Shall I close this one?

@michaelmckinsey1

Copy link
Copy Markdown
Contributor Author

#335 merged. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants