Repository navigation
Fix catmull curve call crashing with numpy>=2.4.0 - #125
Merged
Merged
Conversation
Lekuruu
reviewed
Jan 23, 2026
Comment on lines
+445
to
+446
| px = px[0] | ||
| py = py[0] |
There was a problem hiding this comment.
Something to keep in mind is that this returns a numpy float instead of a python float. Not sure if this has an impact, just wanted to mention it.
afaik .item() returns a regular float type
Collaborator
There was a problem hiding this comment.
yes this would be a breaking change, Position should hold normal floats
Liam-DeVoe
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on discord. I don't think this causes any behaviour changes, but my knowledge of numpy floats -> python primative floats isn't really great - we can add the cast back if required.
Example map: https://osu.ppy.sh/beatmapsets/17148#osu/65670
With:
Before:
After: