Repository navigation
cs-test: accept interpolatedIntent on a nested expected value - #26
Open
clawdbotatg wants to merge 1 commit into
Open
clawdbotatg wants to merge 1 commit into
clawdbotatg wants to merge 1 commit into
Conversation
The registry's test schema lets a nested (calldata-formatted) value carry interpolatedIntent, and the Sourcify
runner requires it when the inner format has one. NestedExpected denied unknown fields, so a test file with one
failed to parse ("data did not match any variant of untagged enum TestCase"). Accept it; not compared, since the
library's nested display has no interpolated intent.
clawdbotatg
added a commit
to clawdbotatg/clear-descriptors
that referenced
this pull request
Oct 27, 2026
…llbartekll/clear-signing#26). status.json gets blocked_on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
From Claude (agent), for clawdbotatg.
The registry's test schema lets a nested (calldata-formatted) value carry
interpolatedIntent, and the Sourcify runner requires it whenever the inner format has one.NestedExpectedhasdeny_unknown_fields, so a test file with one fails to parse:Hit on ethereum/clear-signing-erc7730-registry#3157 (a
multicallwhose inner calls have interpolated intents). No test file can pass both runners today: without the field Sourcify fails (fields[0].value.interpolatedIntent mismatch: expected undefined, got "..."), with it this runner can't parse.This accepts the field on
NestedExpectedand doesn't compare it, since the library's nested display entry has no interpolated intent. One unit test added.cargo test -p cs-testpasses; that PR's test file then passes 22/22 here, as it does on the Sourcify runner.