Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
calldatafield with an array path such as#.data.[]currently bypasses nested rendering and produces raw bytes. Nested calls also discard their interpolated intent, andcs-testrejects the registry's valid nestedinterpolatedIntentexpectations before executing any cases.Route calldata-array elements through the nested renderer in both calldata and EIP-712 flows, retain interpolated intents at every nested level, and parse, compare, and serialize them in
cs-test. Unknown inner selectors remain visible as raw calldata; empty batches and interpolation-failure diagnostics retain their existing behavior. Update the generated Swift and React Native nested-call codecs and their display consumers for the added field.The change adds an optional field to
DisplayEntry::Nested; downstream Rust consumers with exhaustive patterns must accommodate that field.Validation:
cargo test --workspace --locked: 446 passing tests.cargo test -p clear-signing --features uniffi,github-registry --locked: 423 passing tests.cargo fmt --all --checkandcargo clippy -p clear-signing --all-targets --features uniffi,github-registry -- -D warningspass.10605baand pass with the fix; runner tests cover nested expectation parsing, comparison, and output serialization.