Skip to content

Render calldata arrays with nested interpolated intents - #17

Closed
1kresh wants to merge 1 commit into
llbartekll:mainfrom
1kresh:codex/fix-nested-calldata-intents
Closed

1kresh wants to merge 1 commit into
llbartekll:mainfrom
1kresh:codex/fix-nested-calldata-intents

Conversation

@1kresh

@1kresh 1kresh commented Sep 21, 2026 •

Copy link
Copy Markdown

A calldata field with an array path such as #.data.[] currently bypasses nested rendering and produces raw bytes. Nested calls also discard their interpolated intent, and cs-test rejects the registry's valid nested interpolatedIntent expectations before executing any cases.

Route calldata-array elements through the nested renderer in both calldata and EIP-712 flows, retain interpolated intents at every nested level, and parse, compare, and serialize them in cs-test. Unknown inner selectors remain visible as raw calldata; empty batches and interpolation-failure diagnostics retain their existing behavior. Update the generated Swift and React Native nested-call codecs and their display consumers for the added field.

The change adds an optional field to DisplayEntry::Nested; downstream Rust consumers with exhaustive patterns must accommodate that field.

Validation:

  • cargo test --workspace --locked: 446 passing tests.
  • cargo test -p clear-signing --features uniffi,github-registry --locked: 423 passing tests.
  • cargo fmt --all --check and cargo clippy -p clear-signing --all-targets --features uniffi,github-registry -- -D warnings pass.
  • The React Native package and example typechecks pass. Its binding diff contains only the generated nested-intent changes; pre-existing decryption-related binding drift is outside this fix.
  • Regenerated Swift bindings typecheck against the generated module map, and the three updated wallet files parse. A full Swift package/app build was not performed because this checkout has no generated XCFramework.
  • Four engine regressions fail on 10605ba and pass with the fix; runner tests cover nested expectation parsing, comparison, and output serialization.
  • All 642 Symbiotic registry reference cases pass, including nested multicalls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant