Repository navigation
Conversation
KEDA's HPA owns the live replica count, but redeploying replaces it with scale.min and can remove capacity under load. Preserve the count within new bounds while raw keeps its fixed count. Assisted-by: Codex (gpt-6.1-sol) Signed-off-by: Elvand Lie Nababan <elvandlie@gmail.com>
preserveAutoscaledReplicas dereferenced desired.Spec.Replicas after only checking the existing deployment. A nil desired deployment, or one with no replica count, panicked. Return in that case, the same as a nil existing count. generateDeployment still always sets the count before update.
Owner
Author
|
Not needed: knative#4089 handled via a findings comment to the author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal pre-check of a rebased suggestion for knative#4089 (author: @Elvand-Lie; their commit is unchanged apart from the rebase). Not a takeover, and not for merge. Nothing here is pushed to their branch.
Tip:
ae40612d07df14730e9c343bc69423fe6d3cd9a9The author commit keeps live
spec.replicason update when the keda deployer opts in, after the deployment (including a Kafka sidecar) is generated. One commit on top makespreserveAutoscaledReplicasreturn instead of panicking when the desired deployment, or its replica count, is nil.