Repository navigation
Conversation
Subscribe and invoke said "Of if", invoke pointed at path/to/you/function, and the config help line dropped the closing quote. The new wrapper tests only checked a shared prefix and never mapped the cluster or not-running sentinels. Match the wording of the other commands, and test the sentinel mapping and the config volumes command path.
Owner
Author
|
Pre-check for knative#3837, merged upstream as eb77e83. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal pre-check of the rebased contributor branch for knative#3837 (author: @cubaseuser123; their commit is unchanged apart from the rebase).
Purpose: run the full Actions suite on our fork before any force-push to the contributor's branch. Not for merge — close once the upstream push happens.
Tip:
148a89ec69c66e2b9efe2abd667d0b9f49d52759On top of the rebased contributor commit, ours fixes help text that did not match the other commands (
Of if,path/to/you/function, and a missing closing quote onfunc config --help) and tests the wrappers by behavior: command-specific text, the cluster and not-running sentinels, andfunc config volumesfrom an uninitialized directory.This commit also still carries the describe/invoke wrappers, because knative#3773 has not landed. Expect a rebase onto main after that merge.