Repository navigation
Conversation
Return an already-wrapped CLI ErrNotInitialized unchanged, and map fn.ErrNotInitialized like wrapDescribeError/wrapDeleteError. Fix the invoke guidance typos (Of→Or, you→your) and match the two-space Try-this formatting used by the run/describe cases. Signed-off-by: Luke Kingland <luke@lukekingland.com>
Owner
Author
|
Pre-check for knative#3773, merged upstream as 4e833b0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal pre-check of the rebased contributor branch for knative#3773 (author: @cubaseuser123; authorship of the original two commits preserved).
Purpose: run the full Actions suite on our fork before any force-push to the contributor's branch. Not for merge — close once the upstream push happens.
Tip:
68acd497ac9dOn top of the rebased contributor commits, one commit of ours aligns
wrapInvokeErrorwith the sibling wrappers (return already-wrapped CLIErrNotInitializedunchanged; mapfn.ErrNotInitialized), and fixes the invoke guidance typos (Of→Or,you→your) plus Try-this formatting.Confirmed:
invoke.go's hardcoded "no function found" text is fully replaced byNewErrNotInitializedFromPath.Sibling note: knative#3837 (same author) is in parallel on @coder.functions.1 and will rebase onto this after merge.