Repository navigation
Fix discovery package in Docker build context - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The one-line addition follows the existing allowlist pattern and addresses the missing package without unrelated changes.
No open issues 🎉
What changed in this PR
This PR fixes the release Docker build context by including the discovery package needed to compile the project’s binaries.
Changes:
- Adds
!discovery/to the existing Docker context allowlist, including itssharedsubpackage.
| File | Description |
|---|---|
.dockerignore |
Includes discovery/ in the Docker build context. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release Docker build excludes the new
discoverypackage from its allowlisted context, so both Linux builds fail with missingdiscoveryanddiscovery/sharedimports. Includediscovery/in.dockerignoreso the existing release builds and smoke tests can compile and exercise all five binaries.Validation passed:
git diff --check.Fixes the build failure in https://github.com/livepeer/node/actions/runs/39925104071.