Skip to content

Fix discovery package in Docker build context - #4

Merged
j0sh merged 1 commit into
mainfrom
ja-codex/fix-discovery-docker-context
Oct 23, 2026
Merged

j0sh merged 1 commit into
mainfrom
ja-codex/fix-discovery-docker-context

Conversation

@j0sh

@j0sh j0sh commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

The release Docker build excludes the new discovery package from its allowlisted context, so both Linux builds fail with missing discovery and discovery/shared imports. Include discovery/ in .dockerignore so the existing release builds and smoke tests can compile and exercise all five binaries.

Validation passed:

  • Linux amd64 and arm64 release builds, including static-link checks, archive smoke tests, and image smoke tests.
  • Go checks, including race and SDK integration tests, vet, staticcheck, and vulnerability scanning.
  • Local Linux arm64 build using only the allowlisted Docker context; git diff --check.

Fixes the build failure in https://github.com/livepeer/node/actions/runs/39925104071.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The one-line addition follows the existing allowlist pattern and addresses the missing package without unrelated changes.

No open issues 🎉

What changed in this PR

This PR fixes the release Docker build context by including the discovery package needed to compile the project’s binaries.

Changes:

  • Adds !discovery/ to the existing Docker context allowlist, including its shared subpackage.
File Description
.dockerignore Includes discovery/ in the Docker build context.

Review effort: Balanced

@j0sh
j0sh merged commit 6d7312a into main Oct 23, 2026
6 checks passed
@j0sh
j0sh deleted the ja-codex/fix-discovery-docker-context branch October 23, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants