Skip to content

Repository navigation

Fix draft release lookup after creation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j0sh merged 1 commit into from
Oct 27, 2026
Merged

Fix draft release lookup after creation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/scripts/test-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,18 @@ case "$*" in
api\ */commits/*\ --jq\ .sha) cat "$STATE/commit" ;;
api\ --paginate\ --slurp\ */releases\?per_page=100)
[[ ! -f "$STATE/api-error" ]] || exit 1
if [[ -f "$STATE/stale-list" && -f "$STATE/created" ]]; then
echo '[[{"id":8,"tag_name":"v0.0.0","draft":false}]]'
exit 0
fi
jq -s '[[{id: 8, tag_name: "v0.0.0", draft: false}], .]' "$STATE/release" ;;
api\ --paginate\ --slurp\ */assets\?per_page=100)
jq -s '[[], .]' "$STATE/assets" ;;
"release create $RELEASE_TAG --repo $GH_REPO --verify-tag --draft --generate-notes --title $RELEASE_TAG")
"api --method POST repos/$GH_REPO/releases -f tag_name=$RELEASE_TAG -f target_commitish=$RELEASE_COMMIT -f name=$RELEASE_TAG -F draft=true -F prerelease=false -F generate_release_notes=true")
echo create >> "$STATE/writes"
echo '{"id":7,"tag_name":"v1.2.3","draft":true,"prerelease":false}' > "$STATE/release" ;;
echo '{"id":7,"tag_name":"v1.2.3","draft":true,"prerelease":false}' > "$STATE/release"
touch "$STATE/created"
cat "$STATE/release" ;;
"release upload $RELEASE_TAG --repo $GH_REPO --clobber "*)
jq -e .draft "$STATE/release" > /dev/null
echo upload >> "$STATE/writes"
Expand Down Expand Up @@ -97,6 +103,7 @@ reject bash "$ROOT/release.sh" --authorize
rm "$STATE/permission-error"

reset_github() {
rm -f "$STATE/created"
: > "$STATE/release"
: > "$STATE/assets"
: > "$STATE/writes"
Expand Down Expand Up @@ -233,6 +240,12 @@ for failure in missing extra digest; do
test "$(cat "$STATE/writes")" = $'create\nupload\nedit'
done

reset_github
# Creation must succeed even while the releases list omits the new draft.
touch "$STATE/stale-list"
release --publish
test "$(cat "$STATE/writes")" = $'create\nupload\nedit'
rm "$STATE/stale-list"
reset_github
touch "$STATE/interrupt"
reject release --publish
Expand Down
12 changes: 9 additions & 3 deletions release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,16 @@ find_release() {
verify_tag
release=$(find_release)
if [[ "$release" == null ]]; then
gh release create "$tag" --repo "$repo" --verify-tag --draft --generate-notes --title "$tag"
release=$(find_release)
# The releases list can lag behind creation. Keep the response so a new draft
# does not need to appear in that list before we can upload its assets.
release=$(gh api --method POST "repos/$repo/releases" \
-f tag_name="$tag" -f target_commitish="$commit" -f name="$tag" \
-F draft=true -F prerelease=false -F generate_release_notes=true)
fi
id=$(jq -er .id <<< "$release")
id=$(jq -er .id <<< "$release") || {
echo "Release $tag has no release ID; refusing to publish." >&2
exit 1
}
if jq -e .draft <<< "$release" > /dev/null; then
gh release upload "$tag" --repo "$repo" --clobber "${assets[@]/#/dist/}"
elif ! jq -e '.prerelease == false' <<< "$release" > /dev/null; then
Expand Down
Loading