Let you point the Azure uploader at a custom endpoint#32
Open
apoorva-01 wants to merge 1 commit into
Open
Conversation
The host is hardcoded to <account>.blob.core.windows.net in three spots, so there's no way to hit a local Azurite emulator or a sovereign cloud like blob.core.chinacloudapi.cn. Added an optional Endpoint on AzureConfig, same thing S3 and AliOSS already do.
Author
|
bump 🙂 this one's small and green, just adds an optional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
EndpointtoAzureConfig(same as S3/AliOSS) so the uploader can hit a local Azurite or a sovereign cloud like*.blob.core.chinacloudapi.cn. Empty endpoint, nothing changes.Left two calls to you: the issue asks for a
connection_string, but I did anEndpointoverride to keep it small (happy to swap). And it's storage-only, so fully closing egress#634 needs an endpoint on theAzureBlobUploadproto too, henceRefsnotCloses.Tests cover the Azurite + China URLs, everything green.
Refs livekit/egress#634