Fixed release publishing failing to build the javadoc jar - #1024
Merged
davidliu merged 2 commits intoSep 16, 2026
Merged
Conversation
AGP generates the published javadoc with Dokka 1.4.32, which cannot read the sealed classes in livekit-uniffi-android and fails with "PermittedSubclasses requires ASM9". Disabled AGP's javadoc generation and packaged the javadoc jar from the project's Dokka 1.9.20 dokkaJavadoc task instead.
adrian-niculescu
requested review from
MaxHeimbrock,
davidliu and
xianshijing-lk
as code owners
September 16, 2026 11:06
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
…g to the jar Disabling AGP's javadoc generation left any output from an earlier build in place, and the jar, which fails on duplicate files, then packaged it next to the Dokka output. The generation task now syncs the Dokka output into its own output directory, so the jar keeps its single input and stale files are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing the SDK fails since data tracks landed:
publishReleasePublicationToMavenRepository, which the release workflow runs, stops in:livekit-android-sdk:javaDocReleaseGenerationwithUnsupportedOperationException: PermittedSubclasses requires ASM9. CI doesn't catch it because the publish step only runs for snapshot versions.withJavadocJar()makes AGP generate the javadoc with the Dokka version it bundles: 1.4.32 in the AGP 8.7.2 used here, and still in 8.12.1. That Dokka's class reader can't parse the sealed classes inlivekit-uniffi-android, which is now on the SDK's compile classpath. This replaces the action of AGP's generation task with a sync of the project's owndokkaJavadoc(Dokka 1.9.20) output into that task's output directory, so AGP's javadoc jar and the publication's javadoc artifact stay as they are, and output left from an earlier AGP run is removed rather than packaged.Tested with
./gradlew publishReleasePublicationToMavenLocal -PRELEASE_SIGNING_ENABLED=false -Dorg.gradle.parallel=false: it fails on main and publishes all four modules with this change, and the SDK's javadoc jar includes the data track classes.