Skip to content

Subscriber stops applying remote ICE candidates after an ice restart #1017

Description

@avosa

PeerConnectionTransport sets restartingIce to true when it builds an ice restart offer. Only setRemoteDescription sets it back to false. After an ordinary resume the server does not send the subscriber a new offer, so the flag stays true for the life of the transport and every candidate after that goes into pendingCandidates instead of the peer connection. The subscriber can no longer take any path the server proposes, so the person is still heard and hears nothing.

The same thing was fixed in the web SDK in livekit/client-sdk-js#2054. The conclusion there was that queueing gains nothing, because the server does not send candidates ahead of the offer that introduces them.

Seen on 2.27.0. The code is unchanged on 2.28.2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions