Leave curl in image#31
Closed
chessmango wants to merge 1 commit intolinuxserver:mainfrom
chessmango:main
Closed
Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
Contributor
Author
|
Figured I'd take a security-conscious approach here for my own stuff, and just switched to The offer to document health checks still stands, in case that's relevant to other interests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This re-adds/avoids deleting the
curlpackage from the final image, which matches version 1.xxBenefits of this PR and context:
curlis a nice-to-have to enable health checks and have downstream services start when socket-proxy is fully ready and Docker's_pingendpoint is available. Not sure how LSIO feels about prescriptive guidance, but I could also add some extras to the readme about how to do this with plain Docker and Docker Compose.How Has This Been Tested?
Built a container 🤷 not much change
Source / References: