Conversation
1. Add enableBehindWindowBlur property to DialogWindow with default true 2. Bind StyledBehindWindowBlur visibility to this new property 3. Disable behind window blur in SettingsDialog for better performance 4. Set SettingsDialog background to palette.base instead of transparent 5. Add rounded corner styling to SettingsDialog content background 6. Enable clipping on navigation and content ListViews to prevent overflow 7. Restructure content padding using individual padding properties Log: Added blur control option for dialog windows and improved settings dialog appearance Influence: 1. Test dialog windows with blur enabled/disabled to verify visual effects 2. Verify SettingsDialog displays correctly without blur effect 3. Check rounded corner appearance on settings content background 4. Test navigation list scrolling with clip enabled 5. Verify content list scrolling behavior with clip property 6. Test dialog window on different platforms for blur compatibility 7. Verify padding changes don't break layout on various screen sizes feat: 为 DialogWindow 添加窗口模糊控制 1. 为 DialogWindow 添加 enableBehindWindowBlur 属性,默认值为 true 2. 将 StyledBehindWindowBlur 的可见性绑定到新属性 3. 在 SettingsDialog 中禁用窗口后模糊以提升性能 4. 将 SettingsDialog 背景设置为 palette.base 而非透明 5. 为 SettingsDialog 内容背景添加圆角样式 6. 启用导航和内容 ListView 的裁剪以防止溢出 7. 使用独立的内边距属性重构内容布局 Log: 新增对话框窗口模糊控制选项并改进设置对话框外观 Influence: 1. 测试启用/禁用模糊效果的对话框窗口,验证视觉效果 2. 验证 SettingsDialog 在无模糊效果下的显示是否正确 3. 检查设置内容背景的圆角外观 4. 测试启用裁剪后的导航列表滚动 5. 验证内容列表在裁剪属性下的滚动行为 6. 在不同平台上测试对话框窗口的模糊兼容性 7. 验证内边距更改不会在各种屏幕尺寸下破坏布局 PMS: BUG-378325
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideIntroduces configurable behind-window blur for DialogWindow and uses it to optimize SettingsDialog, while refining its background, rounded-corner presentation, list clipping, and content layout padding. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="qt6/src/qml/settings/SettingsDialog.qml" line_range="63" />
<code_context>
top: control.top
}
- padding: DS.Style.settings.content.margin
+ height: Math.max(0, control.height - parent.y)
+ leftPadding: DS.Style.settings.content.margin
+ rightPadding: DS.Style.settings.content.margin
</code_context>
<issue_to_address>
**issue (bug_risk):** `contentBg.height` creates a binding loop: `DialogWindow.height` is bound to `content.height`, `content.height` is derived from its children's bounds, and `contentBg.height` is bound back to `control.height`. QML reports a binding loop and the settings content height becomes unstable or resolves incorrectly, causing the dialog layout to collapse or display at the wrong height.
**Triggers:** When SettingsDialog is instantiated and its window size is evaluated.
**Suggested fix:** Give the content view a height derived from an independent parent/content height, or establish an explicit dialog height without binding the child height back to `control.height`.
</issue_to_address>This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Added blur control option for dialog windows and improved settings dialog appearance
Influence:
feat: 为 DialogWindow 添加窗口模糊控制
Log: 新增对话框窗口模糊控制选项并改进设置对话框外观
Influence:
PMS: BUG-378325
Summary by Sourcery
Add configurable dialog blur behavior and refine the SettingsDialog layout and appearance.
New Features:
Bug Fixes:
Enhancements: