Skip to content

feat: add window blur control to DialogWindow - #713

Open
wjyrich wants to merge 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-378325
Open

wjyrich wants to merge 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-378325

Conversation

@wjyrich

@wjyrich wjyrich commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor
  1. Add enableBehindWindowBlur property to DialogWindow with default true
  2. Bind StyledBehindWindowBlur visibility to this new property
  3. Disable behind window blur in SettingsDialog for better performance
  4. Set SettingsDialog background to palette.base instead of transparent
  5. Add rounded corner styling to SettingsDialog content background
  6. Enable clipping on navigation and content ListViews to prevent overflow
  7. Restructure content padding using individual padding properties

Log: Added blur control option for dialog windows and improved settings dialog appearance

Influence:

  1. Test dialog windows with blur enabled/disabled to verify visual effects
  2. Verify SettingsDialog displays correctly without blur effect
  3. Check rounded corner appearance on settings content background
  4. Test navigation list scrolling with clip enabled
  5. Verify content list scrolling behavior with clip property
  6. Test dialog window on different platforms for blur compatibility
  7. Verify padding changes don't break layout on various screen sizes

feat: 为 DialogWindow 添加窗口模糊控制

  1. 为 DialogWindow 添加 enableBehindWindowBlur 属性,默认值为 true
  2. 将 StyledBehindWindowBlur 的可见性绑定到新属性
  3. 在 SettingsDialog 中禁用窗口后模糊以提升性能
  4. 将 SettingsDialog 背景设置为 palette.base 而非透明
  5. 为 SettingsDialog 内容背景添加圆角样式
  6. 启用导航和内容 ListView 的裁剪以防止溢出
  7. 使用独立的内边距属性重构内容布局

Log: 新增对话框窗口模糊控制选项并改进设置对话框外观

Influence:

  1. 测试启用/禁用模糊效果的对话框窗口,验证视觉效果
  2. 验证 SettingsDialog 在无模糊效果下的显示是否正确
  3. 检查设置内容背景的圆角外观
  4. 测试启用裁剪后的导航列表滚动
  5. 验证内容列表在裁剪属性下的滚动行为
  6. 在不同平台上测试对话框窗口的模糊兼容性
  7. 验证内边距更改不会在各种屏幕尺寸下破坏布局

PMS: BUG-378325

Summary by Sourcery

Add configurable dialog blur behavior and refine the SettingsDialog layout and appearance.

New Features:

  • Add configurable behind-window blur support to dialog windows, enabled by default.

Bug Fixes:

  • Prevent navigation and content list content from overflowing their bounds in SettingsDialog.

Enhancements:

  • Improve SettingsDialog performance and visual presentation by disabling blur, applying themed backgrounds with rounded content styling, and refining layout padding.

1. Add enableBehindWindowBlur property to DialogWindow with default true
2. Bind StyledBehindWindowBlur visibility to this new property
3. Disable behind window blur in SettingsDialog for better performance
4. Set SettingsDialog background to palette.base instead of transparent
5. Add rounded corner styling to SettingsDialog content background
6. Enable clipping on navigation and content ListViews to prevent
overflow
7. Restructure content padding using individual padding properties

Log: Added blur control option for dialog windows and improved settings
dialog appearance

Influence:
1. Test dialog windows with blur enabled/disabled to verify visual
effects
2. Verify SettingsDialog displays correctly without blur effect
3. Check rounded corner appearance on settings content background
4. Test navigation list scrolling with clip enabled
5. Verify content list scrolling behavior with clip property
6. Test dialog window on different platforms for blur compatibility
7. Verify padding changes don't break layout on various screen sizes

feat: 为 DialogWindow 添加窗口模糊控制

1. 为 DialogWindow 添加 enableBehindWindowBlur 属性,默认值为 true
2. 将 StyledBehindWindowBlur 的可见性绑定到新属性
3. 在 SettingsDialog 中禁用窗口后模糊以提升性能
4. 将 SettingsDialog 背景设置为 palette.base 而非透明
5. 为 SettingsDialog 内容背景添加圆角样式
6. 启用导航和内容 ListView 的裁剪以防止溢出
7. 使用独立的内边距属性重构内容布局

Log: 新增对话框窗口模糊控制选项并改进设置对话框外观

Influence:
1. 测试启用/禁用模糊效果的对话框窗口,验证视觉效果
2. 验证 SettingsDialog 在无模糊效果下的显示是否正确
3. 检查设置内容背景的圆角外观
4. 测试启用裁剪后的导航列表滚动
5. 验证内容列表在裁剪属性下的滚动行为
6. 在不同平台上测试对话框窗口的模糊兼容性
7. 验证内边距更改不会在各种屏幕尺寸下破坏布局

PMS: BUG-378325
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Reviewer's Guide

Introduces configurable behind-window blur for DialogWindow and uses it to optimize SettingsDialog, while refining its background, rounded-corner presentation, list clipping, and content layout padding.

File-Level Changes

Change Details Files
Adds an opt-in control for the dialog’s behind-window blur effect.
  • Introduces enableBehindWindowBlur with a default of true.
  • Binds the blur component’s visibility to the new property.
qt6/src/qml/DialogWindow.qml
Optimizes and restyles the settings dialog for a non-blurred presentation.
  • Disables behind-window blur and uses the base palette color for the window.
  • Adds a layered palette-based background with rounded corners.
  • Enables clipping on navigation and content lists.
  • Replaces aggregate content padding with explicit side-specific padding and adjusts content height.
qt6/src/qml/settings/SettingsDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="qt6/src/qml/settings/SettingsDialog.qml" line_range="63" />
<code_context>
             top: control.top
         }
-        padding: DS.Style.settings.content.margin
+        height: Math.max(0, control.height - parent.y)
+        leftPadding: DS.Style.settings.content.margin
+        rightPadding: DS.Style.settings.content.margin
</code_context>
<issue_to_address>
**issue (bug_risk):** `contentBg.height` creates a binding loop: `DialogWindow.height` is bound to `content.height`, `content.height` is derived from its children's bounds, and `contentBg.height` is bound back to `control.height`. QML reports a binding loop and the settings content height becomes unstable or resolves incorrectly, causing the dialog layout to collapse or display at the wrong height.

**Triggers:** When SettingsDialog is instantiated and its window size is evaluated.

**Suggested fix:** Give the content view a height derived from an independent parent/content height, or establish an explicit dialog height without binding the child height back to `control.height`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread qt6/src/qml/settings/SettingsDialog.qml

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants