fix: resolve UI centering and alignment issues - #747
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideThis PR refines multiple QML delegates and views to fix vertical and horizontal centering issues, align text and controls consistently, and make playlist item widths responsive while adding a numbered column and play button behavior to the artist sublist. Sequence diagram for ArtistSublistDelegate play button behaviorsequenceDiagram
actor User
participant ArtistSublistDelegate
participant Presenter
User ->> ArtistSublistDelegate: onClicked (playActionButton)
alt [playing && activeMeta]
ArtistSublistDelegate ->> Presenter: pause()
else [not playing || not activeMeta]
ArtistSublistDelegate ->> Presenter: playArtist(artist, hash)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
163cbd0 to
00bb4b9
Compare
|
TAG Bot New tag: 7.0.63 |
|
TAG Bot New tag: 7.0.64 |
00bb4b9 to
f8cabfc
Compare
|
TAG Bot New tag: 7.0.65 |
|
TAG Bot New tag: 7.0.66 |
f8cabfc to
9872917
Compare
|
代码审查反馈(V-3031)— 建议修复 数字列新增的 playActionButton 为死代码
建议:要么补全"行号→hover 显示播放键"的切换( 其余改动正确:垂直居中、空安全( 次要: |
9872917 to
aa98b80
Compare
@lzwind 已删除 playActionButton 和 playing/activeMeta 两个属性 grabToImage 问题也删除了,计划未来新开个PR 单独处理这个问题 |
- Fix vertical centering of title column and time text in Toolbar - Add vertical alignment to title label in AllMusicListDelegate - Fix playlist delegate horizontal centering and dynamic width in CurrentPlayList - Adjust header column width and title offset in ArtistSublistView - Fix text vertical centering in WaveformRect - Add row number column and play button centering in ArtistSublistDelegate fix: 解决UI居中和对齐问题 - 修复工具栏标题列和时间文本的垂直居中 - 在AllMusicListDelegate中为标题标签添加垂直对齐 - 修复播放列表委托的水平居中和动态宽度 - 调整ArtistSublistView中的标题列宽度和偏移 - 修复WaveformRect中的文本垂直居中 - 在ArtistSublistDelegate中添加行号列和播放按钮居中
aa98b80 to
27c28f5
Compare
|
/forcemerge |
|
This pr force merged! (status: blocked) |
fix: 解决UI居中和对齐问题
Summary by Sourcery
Improve music player layout consistency by centering UI elements and making list and playlist columns adapt to their available space.
Bug Fixes:
Enhancements:
Chores: