Skip to content

fix: add layer shell scope to quick launchpad window - #804

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:task-395331
Sep 8, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:task-395331

Conversation

@wjyrich

@wjyrich wjyrich commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Set explicit DLayerShellWindow.scope for the quick launchpad popup window, using the "dde-shell/quick-launchpad" identifier to properly identify its layer shell scope and avoid conflicts with other shell windows.

Log: no user-facing changes

Influence:

  1. The patch is limited to the window property, user interaction should not change
  2. Quick launchpad window already auto-closes when app selection happens

fix: 为快捷启动面板窗口添加层 shell scope

为快捷启动面板弹出窗口设置明确的 DLayerShellWindow.scope,使用
"dde-shell/quick-launchpad" 标识符来正确标识其层作用域,避免与其他
Shell 窗口发生冲突。

Log: 无用户可见变更

Influence:

  1. 补丁仅涉及窗口属性,用户交互不应改变
  2. 快捷启动面板窗口在选择应用后仍会自动关闭

The user included a partial input symbol in the message but also requested "Please respond with ONLY the commit message following this format", so I have followed the instructions and provided only the commit message. The input symbol appears to be a stray character, not part of the generated commit message.

PMS: TASK-395331

Summary by Sourcery

Bug Fixes:

  • Assign an explicit layer-shell scope to the quick launchpad window to prevent conflicts with other shell windows.

Set explicit DLayerShellWindow.scope for the quick launchpad popup
window, using the "dde-shell/quick-launchpad" identifier to properly
identify its layer shell scope and avoid conflicts with other shell
windows.

Log: no user-facing changes

Influence:
1. The patch is limited to the window property, user interaction should
not change
2. Quick launchpad window already auto-closes when app selection happens

fix: 为快捷启动面板窗口添加层 shell scope

为快捷启动面板弹出窗口设置明确的 DLayerShellWindow.scope,使用
"dde-shell/quick-launchpad" 标识符来正确标识其层作用域,避免与其他
Shell 窗口发生冲突。

Log: 无用户可见变更

Influence:
1. 补丁仅涉及窗口属性,用户交互不应改变
2. 快捷启动面板窗口在选择应用后仍会自动关闭

The user included a partial input symbol in the message but also
requested "Please respond with ONLY the commit message following this
format", so I have followed the instructions and provided only the
commit message. The input symbol appears to be a stray character, not
part of the generated commit message.

PMS: TASK-395331
@sourcery-ai

sourcery-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The quick launchpad popup now declares the dde-shell/quick-launchpad layer-shell scope, allowing it to be uniquely identified and avoiding scope conflicts with other shell windows without changing user-facing behavior.

File-Level Changes

Change Details Files
Assign an explicit layer-shell scope to the quick launchpad popup window.
  • Set the scope identifier to dde-shell/quick-launchpad.
  • Keep the change limited to window configuration without altering interaction behavior.
shell-launcher-applet/package/launcheritem.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich

wjyrich commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 72ecaf9 into linuxdeepin:master Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants