Repository navigation
fix: Reboot transactional systems when packages are staged but not live - #347
Conversation
On a transactional system the package install is only staged, so a re-run after an unset or false podman_transactional_update_reboot_ok reports ok and never reboots. Also check whether the packages are live (rpm -q --whatprovides) and make the reboot condition null-safe. Signed-off-by: HVSharma12 <harshvardhan.sharma@suse.com>
|
CI tests do not run automatically on pull requests. A role repository See GitHub CI testing using /citest Run every available CI workflow: Run the linting and other lightweight checks: Run the integration tests (QEMU/container and Testing Farm): Run one or more selected workflows by separating their names with spaces:
Post another |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/citest all |
Enhancement:
On transactional update systems, also trigger the reboot handling when the podman packages are installed but not live yet (rpm -q --whatprovides), and make the reboot condition null-safe.
Reason:
The install is only staged until reboot, so is changed is true only in the run that staged it. After a run with podman_transactional_update_reboot_ok unset or false, a re-run with true reports ok and skips the reboot. None | bool is also deprecated in newer ansible-core.
Result:
A re-run reboots as expected. Non-transactional systems are unaffected. Verified on SLES 16.1 Immutable.
Issue Tracker Tickets (Jira or BZ if any): na