Skip to content

ci: update status when action triggered by issue comment - #314

Merged
richm merged 1 commit into
mainfrom
checks-update-pr-status
Sep 4, 2026
Merged

ci: update status when action triggered by issue comment#314
richm merged 1 commit into
mainfrom
checks-update-pr-status

Conversation

@richm

@richm richm commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

issue comment triggers do not automatically update check status in the PR, so
use separate steps to update them, similar to how the tft.yml workflow works.
For issue comment workflows, ensure that the head_sha is set early in the
workflow and the status is only updated if there is a head_sha.

Create a variable for context so it is created in one place and used in several
places in the workflow.

Ensure that the first steps in the workflow are to get the head_sha and set the
status to In Progress.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • New Features

    • Pull request checks triggered by comments now report a pending status while running and a final status when complete.
    • Commit statuses now identify the relevant check and pull request revision more accurately.
    • Platform-skipped integration checks continue to report an appropriate successful status when applicable.
  • Bug Fixes

    • Improved status reporting for checks run through pull request comments, including completed, failed, and skipped outcomes.
    • Added fallback handling to ensure checks can still reference the correct revision when pull request metadata is unavailable.

@richm richm self-assigned this Sep 4, 2026
issue comment triggers do not automatically update check status in the PR, so
use separate steps to update them, similar to how the tft.yml workflow works.
For issue comment workflows, ensure that the head_sha is set early in the
workflow and the status is only updated if there is a head_sha.

Create a variable for context so it is created in one place and used in several
places in the workflow.

Ensure that the first steps in the workflow are to get the head_sha and set the
status to In Progress.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: bd44c0eb-80d0-409b-930d-6314223ed36a

📥 Commits

Reviewing files that changed from the base of the PR and between 67a0f57 and 3aafff4.

📒 Files selected for processing (9)
  • .github/workflows/ansible-lint.yml
  • .github/workflows/ansible-managed-var-comment.yml
  • .github/workflows/ansible-test.yml
  • .github/workflows/codespell.yml
  • .github/workflows/markdownlint.yml
  • .github/workflows/qemu-kvm-integration-tests.yml
  • .github/workflows/test_converting_readme.yml
  • .github/workflows/tft.yml
  • .github/workflows/woke.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

The workflows now request statuses: write, resolve pull request head SHAs with status contexts, set pending commit statuses before execution, and set final statuses after execution for issue-comment-triggered runs. The TFT workflow also centralizes status inputs and handles skipped platforms.

Workflow status reporting

Layer / File(s) Summary
Status permissions and execution setup
.github/workflows/*
The workflows add status permissions, derive head_sha and context values, set pending statuses, and use the resolved SHA for checkout. The TFT workflow adds a SHA fallback and centralizes status inputs.
Final and skipped status reporting
.github/workflows/*
The workflows report job.status after execution. The QEMU and TFT workflows update skipped-platform status handling and context usage.

Suggested reviewers: spetrosi

Merge Risk: ⚪ Minimal · up to 3aaff

Comment-triggered workflows now report pending and final commit statuses against the pull request head SHA, improving check visibility without an identified current-head merge risk.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description Format ⚠️ Warning The description does not follow either allowed template. The repository template requires Enhancement:, Reason:, and Result:. The change is a bug fix, so the alternative requires Cause:, `Cons… Rewrite the PR description with the bug-fix sections Cause:, Consequences:, Fix:, and Result:, followed by the existing Signed-off-by: Rich Megginson <rmeggins@redhat.com>. Include the optional issue-tracker section only if applic…
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format with the valid ci type and clearly describes the workflow status updates for issue-comment-triggered runs. ([github.com](https://github.com/linux-system…
Description check ✅ Passed The description is detailed, on topic, and explains the reason, implementation, and expected result. It does not use the template headings and does not state whether Jira or BZ tickets apply, but thes…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title follows Conventional Commits format with the valid ci type and clearly describes the workflow status updates for issue-comment-triggered runs. (github.com)

Full details: Description check

Explanation

The description is detailed, on topic, and explains the reason, implementation, and expected result. It does not use the template headings and does not state whether Jira or BZ tickets apply, but these omissions are non-critical because the required change information is present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (9 skipped: 9 unsupported.)

Full details: Description Format

Explanation

The description does not follow either allowed template. The repository template requires Enhancement:, Reason:, and Result:. The change is a bug fix, so the alternative requires Cause:, Consequences:, Fix:, and Result:. The supplied description has none of these section labels. It does include a valid Signed-off-by: line with a name and email address.

Resolution

Rewrite the PR description with the bug-fix sections Cause:, Consequences:, Fix:, and Result:, followed by the existing Signed-off-by: Rich Megginson &lt;rmeggins@redhat.com&gt;. Include the optional issue-tracker section only if applicable.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richm
richm merged commit b6e8787 into main Sep 4, 2026
13 checks passed
@richm
richm deleted the checks-update-pr-status branch September 4, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant