Repository navigation
Conversation
With namespace sync on, the host cache watched every namespace, so the syncer needed cluster-wide RBAC for secrets, pods, exec and workloads. When mappingsOnly is set and every mapping is exact, the syncer only ever works in the mapped host namespaces plus its own, so the cache is limited to those and the RBAC can be namespaced Roles. This needs no more permissions than before, so it runs with either RBAC setup. Host Gateway import keeps its own per-object namespaces as without namespace sync. Additional kubeconfig secret namespaces are added to the scoped set; without it they no longer narrow the cluster-wide cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
sync.toHost.namespacesenabled, the host cache watched every namespace, so the syncer needed cluster-wide RBAC for secrets, pods, exec and workloads.When
mappingsOnlyis set and every mapping is exact, the syncer only works in the mapped host namespaces plus its own. The cache is now limited to those, so the namespaced permissions can be granted with Roles in those namespaces. The scoped cache needs no permissions beyond the cluster-wide setup, so it works with either RBAC setup.mappingsOnlyoff, no mappings, or a wildcard mapping.exportKubeConfig.additionalSecretsnamespaces are added to the scoped set. With namespace sync on and no scoping, they no longer narrow the cache to only the secret namespace.Tests:
pkg/setup/controller_context_namespaces_test.go;go test -race ./pkg/setup/...passes.🤖 Generated with Claude Code