Repository navigation
Conversation
When -o points at a nested path whose directories do not exist yet, create_archive raised FileNotFoundError on target.open. Ensure the parent path exists first. Fixes linkedin#231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-opoints at a nested path whose parent directories do not exist yet,create_archiveraisedFileNotFoundErrorontarget.open.This ensures the parent path exists first (
mkdir(parents=True, exist_ok=True)) before opening the output file — matching what maintainer @lorencarvalho noted on #231.Fixes #231
Test
test_create_archive_creates_missing_parent_dirsPYTHONPATH=src pytest— 60 passed