Repository navigation
Test extraction path isolation for dotted archive names - #285
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Closes linkedin#203. Prepared with Codex assistance. Signed-off-by: Shubham Padkonde <shubhampadkonde12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203 by adding the regression coverage requested after the extraction-path fix was merged.
The test creates and extracts two real archives named with dotted versions, both with and without a
.pyzextension. It checks that:Both parameter cases pass on current main. Restoring
.stemincache_pathmakes both fail; independently restoring.stemin the temporary/lock path calculation also makes both fail. Production code is unchanged.Validation: full Linux Python 3.11.15 suite 61 passed; mypy passes for all 12 source files; full flake8 passes. No concurrency stress-test or Windows test run is claimed.
Prepared with Codex assistance.