Support BaseDexClassLoader in AppDataDirGuesser#212
Open
lev-rumyantsev wants to merge 1 commit into
Open
Conversation
AppDataDirGuesser was strictly casting the ClassLoader to PathClassLoader. This fails if the test is run under a different ClassLoader (like DexClassLoader or InMemoryDexClassLoader), which can happen in automated test runs or guest execution environments. By casting to BaseDexClassLoader instead, we support all standard Android class loaders since they all inherit from BaseDexClassLoader and use DexPathList internally. Also added a fallback to ActivityThread.currentApplication().getCacheDir() if the class loader guessing still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppDataDirGuesser was strictly casting the ClassLoader to PathClassLoader.
This fails if the test is run under a different ClassLoader (like DexClassLoader
or InMemoryDexClassLoader), which can happen in automated test runs or guest
execution environments.
By casting to BaseDexClassLoader instead, we support all standard Android
class loaders since they all inherit from BaseDexClassLoader and use DexPathList
internally.
Also added a fallback to ActivityThread.currentApplication().getCacheDir()
if the class loader guessing still fails.