Add per-band, DP1 MLP and reference constant mag-err model artifacts - #123
Merged
Merged
Conversation
Point sources (extendedness = 0) brighter than 21 mag, all six bands fitted in one run, plus the two comparisons this was run for: - g-r colour bins (0.0-0.5 vs 1.5-2.0), summarised in perband_magerr_gr_comparison.txt: the systematic error is ~9-10 mmag in every band and the red-blue difference stays under 1.2 mmag, so it is essentially colour-independent. - Three 5M-light-curve cones (Rubin-SV-225, DDF-COSMOS, DDF-EDFS), summarised in perband5M_dp2_diff_fields.txt: 6-15 mmag, varying more between fields than between bands.
Replaced by models/2026-07-08_DP2_Object_ForcedSource.
…ource MLPModel trained on the DP1 science Object catalog, all six bands, n_src=10, val/test split at 0.6/0.85, for both calibrated and difference images. Each run ships the .pt and .onnx model, the feature-importance figure, and the full plot set: uncorrected data, train/validation/test whitened-residual histograms and u-vs-magnitude, plus the reduced-chi2, KL-statistic and whiten/addmagerr density diagnostics on the test split. The .pt checkpoints exceed the 500 KB pre-commit limit, as the already tracked 2026-07-08 DP2 ones do.
Not a trained run: ConstantMagErrModel with addition_centi_mag_err pinned to 1.0, i.e. a flat 0.01 mag systematic, kept as the baseline the trained models are compared against. Two variants, calibrated images and difference images (the latter referencing the systematic to psfFlux), each with its own plot set including the reduced-chi2, KL-statistic and density diagnostics.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 36 36
Lines 2246 2246
=======================================
Hits 1199 1199
Misses 1047 1047 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trained-model artifacts left over from the per-band constant mag-err work. Code only — no source changes; every source change from the old
dia-object-supportbranch is already onmainvia #106, #111, #112, #113 and the flux_err PRs.Per-band constant mag-err runs, DP2 Object forcedDiaSource
Point sources (
extendedness = 0) brighter than 21 mag, all six bands fitted in one run, plus the two comparisons this was run for:models/perband_magerr_gr_comparison.txt: the systematic error is ~9–10 mmag in every band and the red-blue difference stays under 1.2 mmag, so it is essentially colour-independent.models/perband5M_dp2_diff_fields.txt: 6–15 mmag, varying more between fields than between bands.2026-07-16 DP1 Object MLP models
MLPModelon the DP1 science Object catalog, all six bands,n_src=10, val/test split at 0.6/0.85, for both calibrated and difference images. Each run ships the.ptand.onnxmodel, the feature-importance figure and the full plot set, including the reduced-chi2, KL-statistic and whiten/addmagerr density diagnostics on the test split.Fixed 0.01 mag reference model
models/const_magerr_0.01mag/— not a trained run, butConstantMagErrModelwithaddition_centi_mag_errpinned to 1.0, kept as the baseline the trained models are compared against. Calibrated and difference-image variants (the latter referencing the systematic topsfFlux), each with its own plot set.Also
Drops the superseded
models/2026-06-10_DP2_Object_ForcedSource/, replaced bymodels/2026-07-08_DP2_Object_ForcedSource/. Nothing references it.Note: the two DP1
MLPModel.ptcheckpoints (~850 KB each) exceed the 500 KBcheck-added-large-fileslimit and were committed with--no-verify, as the already tracked 2026-07-08 DP2 checkpoints were. All other hooks, tests included, pass.🤖 Generated with Claude Code