Use YYYY-MM-DD for downloaded orbit file dates - #34
Merged
Merged
Conversation
The --download_orbits path named files like asteroid_orbits_23-09-2026.json.gz, which does not sort chronologically. Switch to ISO dates to match the results/<YYYY-MM-DD>_job_<job> naming. Closes #18 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
maxwest-uw
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
--download_orbitswrote files named with%d-%m-%Y(e.g.asteroid_orbits_23-09-2026.json.gz), which don't sort chronologically. This switches them to%Y-%m-%d.Results files (
results/<date>_job_<job>.*andresults/chunk_runs/<date>_job_...) already useYYYY-MM-DDbecause they come fromdatetime.isoformat(), so this was the last date inDD-MM-YYYYform.chunk_cleanup.RUN_DIR_REalready expects the ISO form.Nothing looks up orbit files by date, so there's no compatibility shim. Existing downloaded files keep their old names.
Testing
test_download_orbits_without_db_skips_analysisnow checks that the date string isYYYY-MM-DDpytest tests: 39 passed🤖 Generated with Claude Code