Skip to content

TS2Vec and demo notebook - #1055

Open
drewoldag wants to merge 16 commits into
mainfrom
awo/ts2vec
Open

drewoldag wants to merge 16 commits into
mainfrom
awo/ts2vec

Conversation

@drewoldag

@drewoldag drewoldag commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Adding ts2vec, and the demo notebook.

This allows for an end to end example of using LSDB to load a HATS catalog with nested light curve data, sending the catalog promise to Hyrax for training and inference with train_stream and infer_stream, then reducing dimensions and plotting a 2d embedding.

@drewoldag drewoldag self-assigned this Sep 19, 2026
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drewoldag
drewoldag added this pull request to stack #1056 September 23, 2026 17:21
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.89459% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.81%. Comparing base (1281289) to head (a4ac2eb).

Files with missing lines Patch % Lines
src/hyrax/models/hyrax_ts2vec.py 86.43% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   70.20%   70.81%   +0.61%     
==========================================
  Files          91       92       +1     
  Lines        8961     9306     +345     
==========================================
+ Hits         6291     6590     +299     
- Misses       2670     2716      +46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from awo/lsdb-dataset to main September 24, 2026 21:36
@drewoldag
drewoldag removed this pull request from stack #1056 September 24, 2026 21:38
@drewoldag drewoldag changed the title WIP - Adding TS2Vec and demo notebook TS2Vec and demo notebook Sep 25, 2026
@drewoldag
drewoldag requested review from maxwest-uw and a lite review from Copilot September 25, 2026 17:25
@drewoldag
drewoldag marked this pull request as ready for review September 25, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical correctness and distributed-training issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 High severity · 1 Medium severity

Open (5)
What changed in this PR

Adds TS2Vec support for ragged LSDB light-curve streams and an end-to-end training/inference demo.

Changes:

  • Adds TS2Vec encoding, normalization, masking, contrastive training, and inference.
  • Adds configuration defaults, model registration, context propagation, and ONNX preprocessing.
  • Preserves nested-column dtypes during LSDB collation and expands tests.

Final findings include critical masking, DDP, deployment configuration, and distributed context issues, plus moderate mask-device and sequence-length validation issues.

File Summary
tests/​hyrax/​test_lsdb_stream_dataset.py Tests dtype-preserving collation.
tests/​hyrax/​test_hyrax_ts2vec.py Tests TS2Vec behavior.
tests/​hyrax/​test_context.py Tests configuration context propagation.
src/​hyrax/​verbs/​verb_registry.py Adds runtime configuration to verb contexts.
src/​hyrax/​verbs/​to_onnx.py Uses training configuration during export.
src/​hyrax/​models/​hyrax_ts2vec.py Implements TS2Vec and light-curve encoding.
src/​hyrax/​models/​__init__.py Registers the model.
src/​hyrax/​hyrax_default_config.toml Defines TS2Vec defaults.
src/​hyrax/​datasets/​lsdb_stream_dataset.py Preserves nested array dtypes.
src/​hyrax/​context.py Documents runtime configuration context.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/hyrax/models/hyrax_ts2vec.py
Comment thread src/hyrax/models/hyrax_ts2vec.py
Comment thread src/hyrax/models/hyrax_ts2vec.py
Comment thread src/hyrax/verbs/verb_registry.py
Comment thread src/hyrax/models/hyrax_ts2vec.py Outdated
@drewoldag
drewoldag added this pull request to stack #1061 September 28, 2026 16:59
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@drewoldag
drewoldag removed this pull request from stack #1061 September 28, 2026 17:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants