Repository navigation
fix: multiboot always uses the other Keira slot - #39
Closed
black-ghost-off wants to merge 2 commits into
Closed
black-ghost-off wants to merge 2 commits into
black-ghost-off wants to merge 2 commits into
Conversation
With more OTA apps in the partition table (e.g. Retro-Go next to Keira in the lilka-bootloader layout) esp_ota_get_next_update_partition() from app1 returns an app that isn't Keira's. Pick app0/app1 explicitly and fall back to the next OTA partition for other layouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
this problem already solved via making a retrogo sliced onto pieces, so I might not push that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiBootpicked its guest slot withesp_ota_get_next_update_partition(). That only works with the stock two-slot table (app0/app1).The new lilka-bootloader layout keeps Retro-Go next to Keira, so the table has 9 OTA apps. If Keira runs from
app1(after an OTA update), the "next" partition is Retro-Go'slauncher, and multiboot would overwrite it.Now the guest slot is the other one of
app0/app1. If neither exists, it falls back to the next OTA partition as before. Nothing changes for the stock layout.Testing
pio run -e v2).app0and reportsOTA partition: app1.Related Keira PR: lilka-dev/keira#151.
🤖 Generated with Claude Code